From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 74B534696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  1 May 2020 20:00:29 +0300 (MSK)
From: Oleg Babin <olegrok@tarantool.org>
References: <cover.1588292014.git.v.shpilevoy@tarantool.org>
 <badc06d86e3f52b59453184d42f2f1e5d0537e47.1588292014.git.v.shpilevoy@tarantool.org>
Message-ID: <40b31a98-794a-82f6-4332-37996194ac8b@tarantool.org>
Date: Fri, 1 May 2020 20:00:28 +0300
MIME-Version: 1.0
In-Reply-To: <badc06d86e3f52b59453184d42f2f1e5d0537e47.1588292014.git.v.shpilevoy@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH vshard 3/7] test: disable router
	discovery for some tests
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi. Thanks for the patch. LGTM. But I have a question.

On 01/05/2020 03:16, Vladislav Shpilevoy wrote:
> There are tests, which are not related to discovery at all, and
> yet they suffer from unrelated changes, when something is modified
> in the discovery algorithm. For example, it highly affects the
> test about request retries and automatic timeouts.
> 
> Now the discovery is disabled for such tests, since it becomes
> easily possible to do with the new router's configuration option.
> ---
> -_ = test_run:cmd("start server router_1")
> +-- Discovery algorithm changes sometimes and should not affect the
> +-- exponential timeout test.
> +_ = test_run:cmd("start server router_1 with args='discovery_disable'")
>   ---
>   ...
>   _ = test_run:switch('router_1')
> @@ -49,13 +51,13 @@ util.collect_timeouts(rs1)
>       ok: 0
>       timeout: 0.5
>     - fail: 0
> -    ok: 1
> +    ok: 0
>       timeout: 0.5
>   ...
>   util.collect_timeouts(rs2)
>   ---
>   - - fail: 0
> -    ok: 1
> +    ok: 0
>       timeout: 0.5
>     - fail: 0
>       ok: 0
> @@ -74,7 +76,7 @@ util.collect_timeouts(rs1)
>       ok: 0
>       timeout: 0.5
>     - fail: 0
> -    ok: 9
> +    ok: 8
>       timeout: 0.5
>   ...
>   _ = rs1:callrw('echo')
> @@ -86,7 +88,7 @@ util.collect_timeouts(rs1)
>       ok: 0
>       timeout: 0.5
>     - fail: 0
> -    ok: 1
> +    ok: 9
>       timeout: 0.5
>   ...

Sorry for maybe quite stupid question, but why does it quite 
significantly increase?
```
net_sequential_ok - count of sequential success requests to the replica
```