From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [tarantool-patches] Re: [PATCH v2 1/1] netbox: show is_nullable and collation fields References: <82848BBB-2A50-4CAC-852E-E5EE5C8247A3@tarantool.org> <02f53c50-c3eb-9e8c-6d15-9adfb7d23c0d@tarantool.org> <20180327162656.xn7zg3skjgbnmf4m@esperanza> From: Kirill Shcherbatov Message-ID: <404f3c07-5f6f-9db3-abe3-681baeb7b945@tarantool.org> Date: Wed, 28 Mar 2018 10:40:42 +0300 MIME-Version: 1.0 In-Reply-To: <20180327162656.xn7zg3skjgbnmf4m@esperanza> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: en-US To: Vladimir Davydov Cc: "v.shpilevoy@tarantool.org" , tarantool-patches@freelists.org List-ID: Removed extra newline at the end of test file. The branch has been also rebased to the 1.9 diff --git a/test/box/net.box.test.lua b/test/box/net.box.test.lua index 3b4ce05..07555f1 100644 --- a/test/box/net.box.test.lua +++ b/test/box/net.box.test.lua @@ -820,4 +820,3 @@ c.space.test.index.sk.parts  c:close()  box.internal.collation.drop('test')  space:drop() - On 27.03.2018 19:26, Vladimir Davydov wrote: > On Mon, Mar 26, 2018 at 08:41:21PM +0300, Kirill Shcherbatov wrote: >> diff --git a/test/box/net.box.test.lua b/test/box/net.box.test.lua >> index fe45721..3b4ce05 100644 >> --- a/test/box/net.box.test.lua >> +++ b/test/box/net.box.test.lua >> @@ -799,11 +799,9 @@ >> box.schema.user.revoke('guest','read,write,execute','universe') >> >>  space:drop() >> >> - >>  -- >>  -- gh-3256 net.box is_nullable and collation options output >>  -- >> - >>  space = box.schema.create_space('test') >>  box.schema.user.grant('guest','read,write,execute','space', 'test') >>  pk = space:create_index('pk') >> @@ -821,4 +819,5 @@ c = net:connect(box.cfg.listen) >>  c.space.test.index.sk.parts >>  c:close() >>  box.internal.collation.drop('test') >> -space:drop() >> \ No newline at end of file >> +space:drop() >> + > Nit-pick: extra newline at the end of the file. We always add exactly > one newline symbol at the end of each source file. In v1 you added no > newline at all, in v2 you added two newline symbols. Please fix your > editor configuration. > > Other than that, the patch is fine by me.