From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 739C86FC8F; Tue, 23 Mar 2021 03:29:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 739C86FC8F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616459383; bh=7iDJ+MlNXYvEUTG7DLmoQYnT1BFSwpr1nWBsF9eZn2c=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=o1IqxI5nu0VXsANWdkLKpR2lQTUfrAannBYNgywbYXtG3V6/9IoWNMHxTKwQzqpp0 q0BKOLN0w/GbeXJG56GcDB6rJ6yrVJwq5q89syCKEKc6C3ZWRhshWCwhjUfWXa6P0e e9Fzw+WDep5DvURqGcPt2IgKGzHolL2FgOzcporo= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 895026FC8F for ; Tue, 23 Mar 2021 03:29:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 895026FC8F Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lOUvU-00067c-Pb; Tue, 23 Mar 2021 03:29:41 +0300 To: tarantool-patches@dev.tarantool.org, gorcunov@gmail.com, sergepetrenko@tarantool.org References: <2597ce742e96c903138eed83b40c0a447aa66786.1616200860.git.v.shpilevoy@tarantool.org> Message-ID: <4042d0d6-40e0-d021-b3ad-1db487ce52ff@tarantool.org> Date: Tue, 23 Mar 2021 01:29:39 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <2597ce742e96c903138eed83b40c0a447aa66786.1616200860.git.v.shpilevoy@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD95D6E7CC48CB1F5F146FB1591D6F88157BC7E60153CA0047A182A05F538085040365B876AB56935B4B8EFC4F31691E3433BC8403CA46B0529B40543F7D9121C42 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE742D9BD90C58D50E0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D82ED515D6052E03EA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC76646D2B30130DCD61E0C765BEB7D67B9CFF667C765F97A83E3F389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6BAA8CD687FCDB2EBCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E34F43C7A68FF626056395957E7521B51C2D96E472CDF7238E04AD6D5ED66289B5278DA827A17800CE732FCE54C4D9A645493EC92FD9297F6715571747095F342E857739F23D657EF2BD5E8D9A59859A8B64D263EB3BC80FB53089D37D7C0E48F6C5571747095F342E857739F23D657EF2B6825BDBE14D8E70227F01F88B6EF2528BD9CCCA9EDD067B1EDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A513B8D563697ACF0C3FE75213750213F2CD3A5EE4DFA281C2D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3435BBF0AC4E3A921C6D346C88516E168D4ADE36F86AA1FCDB4CD593B90251192C4641597E056F1A5A1D7E09C32AA3244C64D17CE2A7D9F794F96A10DACF6EBD6E5A1673A01BA68E40FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojWJZv20R+6UiPsF0+02MBJg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822C8DF39756BD6F0740FE51024485EAF003841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 07/16] buffer: implement ffi stash X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" > diff --git a/src/lib/core/cord_buf.h b/src/lib/core/cord_buf.h > index 5e65d138b..5ad5290c1 100644 > --- a/src/lib/core/cord_buf.h > +++ b/src/lib/core/cord_buf.h > @@ -21,6 +21,11 @@ cord_ibuf_take(void); > * Put the global ibuf back. It is not necessary - the buffer is put back on the > * next yield. But then it can't be reused/freed until the yield. Put it back > * manually when possible. > + * > + * XXX: buffer auto-put could be made more robust via some amendments. One > + * option - push a cdata with __gc handler on the stack which puts the buffer > + * back, and disable it manually when all worked without errors. The cons is > + * that it is expensive. This comment has nothing to do with the commit. I added it accidentally. Dropped on the branch.