From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4B6A328BE6 for ; Thu, 7 Mar 2019 12:34:32 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xatr6uQ1Jgov for ; Thu, 7 Mar 2019 12:34:32 -0500 (EST) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id EB93329335 for ; Thu, 7 Mar 2019 12:34:31 -0500 (EST) Subject: [tarantool-patches] Re: [PATCH v2 5/7] sql: refactor sql_trigger_step_allocate to set diag References: <607ffbbc4fcdca43ccfc5e6dabaed5ca3bc7719f.1551265819.git.kshcherbatov@tarantool.org> From: Vladislav Shpilevoy Message-ID: <403432db-e4b7-fc6f-73bb-13a98ec2959f@tarantool.org> Date: Thu, 7 Mar 2019 20:34:29 +0300 MIME-Version: 1.0 In-Reply-To: <607ffbbc4fcdca43ccfc5e6dabaed5ca3bc7719f.1551265819.git.kshcherbatov@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Kirill Shcherbatov On 27/02/2019 14:13, Kirill Shcherbatov wrote: > Refactored sql_trigger_step_allocate routine to use diag_set in > case of memory allocation error. Also performed some additional > name refactoring in adjacent places. > This change is necessary because the sql_trigger_step_allocate > body has a sqlNameFromToken call that will be changed in > subsequent patches. But you have changed it in the previous one ... . And here a function with such name already does not exist. The same about the next commit. > > Needed for #3931 > ---