From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 52E0646970E for ; Tue, 24 Dec 2019 19:26:13 +0300 (MSK) References: <20191224012307.GA49851@tarantool.org> From: Vladislav Shpilevoy Message-ID: <400814c8-b019-11d8-1cc6-1b9a6ccbdc22@tarantool.org> Date: Tue, 24 Dec 2019 17:26:11 +0100 MIME-Version: 1.0 In-Reply-To: <20191224012307.GA49851@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 2/2] sql: drop only generated sequence in DROP TABLE List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik , Chris Sosnin Cc: tarantool-patches@dev.tarantool.org Thanks for the review! On 24/12/2019 02:23, Nikita Pettik wrote: > On 18 Dec 14:00, Chris Sosnin wrote: >> create mode 100644 test/sql/autoincrement.result >> create mode 100644 test/sql/autoincrement.test.lua >> >> diff --git a/test/sql/autoincrement.test.lua b/test/sql/autoincrement.test.lua > > Patch itself is LGTM (as obvious). But I am not a big fan of placing each > test in separate file (at least when there's no specific issue for that). As you know, me neither. I added this new file to put here all autoincrement stuff now and in future. We have sql-tap/autoinc, but sql-tap tests are really hard to write and fix. > Moreover, in commit message it is said that this patch is follow-up to > #4546, so could you move this test to gh-4546-sql-drop-grants.test.lua ? 4546 was about table grants. The test in autoincrement file about a different bug - drop of sequence. It is kinda related to 4546 in that sequence grants also should be dropped, if their sequence is deleted.