From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9B1805992AB; Mon, 21 Aug 2023 16:37:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9B1805992AB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692625037; bh=yHROORmSo8PYU0i6x3MouCHlwnRbK6+ne6evr/J704Y=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=rt0BW8KVVRwlc2feXtBc7KWXB/gEPhBomCTDq5h0bLHeA+Qu9XZvl0/J+mwsohQZk C3Lzv1XNWHf/QCoInEWeUtscrvnF9H9IRQhQuoW1wYkA339pBxEXR+s9NGfwJD/MqQ 7GdUKa03G7rLtt2P5qVzSQkgC5lkhFIywq1y50iY= Received: from smtp30.i.mail.ru (smtp30.i.mail.ru [95.163.41.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 68548596289 for ; Mon, 21 Aug 2023 16:37:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 68548596289 Received: by smtp30.i.mail.ru with esmtpa (envelope-from ) id 1qY55m-004nrx-1P; Mon, 21 Aug 2023 16:37:14 +0300 Date: Mon, 21 Aug 2023 16:37:13 +0300 To: Igor Munkin Message-ID: <3up5j2xzvucxt4lbputysr4vlktznlwx7ooixvvmqyz6n5itm2@eordskjb5spw> References: <20230821100604.61363-1-max.kokryashkin@gmail.com> <20230821100604.61363-2-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD93C8852532D76B9E33924516A452DEC2A3E90962AAB48A6A6182A05F5380850405EDF18B55086EE60876F9920EE2AFD2CB75CB3DE10CB6A4EB57618D1559BDE4C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AD2F2D6F6013FF7FC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE70A10A23A3B64B805EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BE5CCB53A13BC8DBA3884CC770E3D5D166A3ED591960FB05CCC7F00164DA146DAFE8445B8C89999728AA50765F79006379BABF3D50D9A3D87389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8A9FF340AA05FB58CF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CF8BD4E506CFA3D889735652A29929C6C4AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3FB892369DDD87097BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFE97D2AE7161E217F1DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3727597FF642BA4D735872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A58F51A69801194D349BC564AE33C460C3D0C3FCDD67FD83D9F87CCE6106E1FC07E67D4AC08A07B9B065B78C30F681404DCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34B8CF715B894FC711E62C9C67AA547EA3CD95E64D22FAF4BBC490B77F52B2E8819107688F603570A71D7E09C32AA3244CBA1FE15FCFFF03917DC2A101FACCF75F51E887DA02A9F7BFBAD658CF5C8AB4025DA084F8E80FEBD396F07DFE06A4A8314E894E437E78228B66933FA05BD8EF0CAD958392AE682691 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHJI2DMjVra2u5p+C2KvPFw== X-Mailru-Sender: 0E9E14D9EC491FBA02AFA918FC4C22CA5004857A6BE3D1F6ED263B81932C6E2FC79FA4167B1C93BED51284F0FE6F529ABC7555A253F5B200DF104D74F62EE79D27EC13EC74F6107F4198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v4 1/3] sysprof: remove `split by vmstate` option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: Maksim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the review! See my answers below. On Mon, Aug 21, 2023 at 01:05:54PM +0000, Igor Munkin wrote: > Max, > > Thanks for the fixes! LGTM, but still one nit regarding the wording. > > On 21.08.23, Maksim Kokryashkin wrote: > > From: Maxim Kokryashkin > > > > The option was introduced early into the sysprof's > > development to provide capabilities for per-VM-state > > callchain visualization. However, during the sysprof's > > recent active in-house usage period, it became clear > > that performance issues associated with specific VM > > states (such as GC, for example) have a distinct look > > on a flamegraph itself, thanks to their name prefixes > > and their surrounding context. > > Minor: Besides, one can still use counters returned by , > right? If so, it would be nice to mention this in reasoning too. Right, added it. Branch is force-pushed. Here is the new commit message: | sysprof: remove `split by vmstate` option | | The option was introduced early into the sysprof's | development to provide capabilities for per-VM-state | callchain visualization. However, during the sysprof's | recent active in-house usage period, it became clear | that performance issues associated with specific VM | states (such as GC, for example) have a distinct look | on a flamegraph itself, thanks to their name prefixes | and their surrounding context. Furthermore, one can | still use counters returned by `sysprof.report` to get | insight into per-VM-state performance. | | This option is unneeded and was never used | by anybody. There is no reason to maintain it | in the scope of refactoring. | | Needed for tarantool/tarantool#8700 > > > > > This option is unneeded and was never used > > by anybody. There is no reason to maintain it > > in the scope of refactoring. > > > > Needed for tarantool/tarantool#8700 > > --- > > tools/sysprof.lua | 9 +-------- > > tools/sysprof/collapse.lua | 10 +++------- > > 2 files changed, 4 insertions(+), 15 deletions(-) > > > > > > > -- > > 2.39.2 (Apple Git-143) > > > > -- > Best regards, > IM