From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id AAD3C8B1BF2; Sun, 3 Dec 2023 15:25:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AAD3C8B1BF2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1701606320; bh=7IxvkIgDG/uWjE8Be//ehzSkKhJmKk6AwyysI7H0njc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=wqRvKrrMv81CuyS0ToS/IpsLqUhI8Wm3jIFlAnEyq0lb9AekdG1WiMGd7ZRVNn34h 8dH5aN+yQ5FxhNF/rqIQO/FDnTqlU6JyQdFGnjpt5BAO0uM5aV1YbxcVYR4kfxQQgA red0QqJcmgt1Xb3xtsMjvnLH5eDEE1Z+OYbWFR14= Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [95.163.41.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E53A9714225 for ; Sun, 3 Dec 2023 15:25:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E53A9714225 Received: by smtp40.i.mail.ru with esmtpa (envelope-from ) id 1r9lXC-000jXC-03; Sun, 03 Dec 2023 15:25:18 +0300 Date: Sun, 3 Dec 2023 15:25:17 +0300 To: Igor Munkin Message-ID: <3tlmhrevpsdeyhzwb32wiuzchz4efwbcgjx5fc2owlg7luloq3@53a4cidfmhcw> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD91486559A3ABF84E7050C572A76A551B96B94F9A1A855CD03182A05F538085040B648037459043EC8566679CE2E303693EB1E5887B54F8EF1BE9176C2D0A1205D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70CB15FA6C489297DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E8F1A1743CF948808638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D82484C09A68E0F219FD20CBDEF219EB50117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF80095D1E57F4578A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18E5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEB28585415E75ADA90A5971FBB7557E96D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE367F1C1C3ABB44F3AAD7EC71F1DB88427C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947C062BEEFFB5F8EA3E2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89FB26E97DCB74E625257739F23D657EF2BB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5074F87F51E5092F71A13F101186F0C2465936A0BD82B957FF87CCE6106E1FC07E67D4AC08A07B9B082B967D547A19D2FCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34F1257DC9690AEBA1326B9BD82E9EE9400CD5B30182A868F00AFD41933F3029C9823E43E8B6095C301D7E09C32AA3244CF64F2592AAA902074C546B3A8BD056D76C2483212766842285A42E4C463514DC5DA084F8E80FEBD396F07DFE06A4A8314E894E437E78228B66933FA05BD8EF0CAD958392AE682691 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojAT457WPMCJxz6B+bv8pKFA== X-Mailru-Sender: 7940E2A4EB16C997B2A36B21676DDA6BFC0F9B08A9B987E0454F93C053C73CCAE2527C969975515CFF9FCECFB8D89CB6C77752E0C033A69E235A20A81F3B0E39AB3C5F247CB2F7F93A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] test: disable buffering for the C test engine X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Maxim Kokryashkin via Tarantool-patches Reply-To: Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM, except for a few typos in the commit message. On Tue, Nov 28, 2023 at 02:53:16PM +0000, Igor Munkin wrote: > Our testing engine for the tests implemented in C introduced in scope of > the commit a0483bd214f2bbc9d7e5fc95ebc0ae13e8d22bcc ("test: introduce > module for C tests") lazily flushes the TAP-formatted report to the > . This might lead to a mess in a report e.g. in case when the Typo: s/e.g. in case/, e.g.,/ > particular case forks a child (that inherits its ) prior to TAP Typo: s/TAP/the TAP/ > header is yield to . Hence the patch disables buffering for Typo: s/is yield/being yielded/ Typo: s/Hence/Hence,/ > before any part of the TAP-formatted report is printed. > > Follows up tarantool/tarantool#7900 > > Signed-off-by: Igor Munkin > --- > test/tarantool-c-tests/test.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/test/tarantool-c-tests/test.c b/test/tarantool-c-tests/test.c > index 7907c12a..0a370cdd 100644 > --- a/test/tarantool-c-tests/test.c > +++ b/test/tarantool-c-tests/test.c > @@ -228,6 +228,12 @@ static int test_run(const struct test_unit *test, size_t test_number, > int _test_run_group(const char *group_name, const struct test_unit tests[], > size_t n_tests, void *test_state) > { > + /* > + * XXX: Disable buffering for stdout to not mess with the > + * output in case there are forking tests in the group. > + */ > + setvbuf(stdout, NULL, _IONBF, 0); > + > test_start_comment(group_name); > > level++; > -- > 2.39.2 >