From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B74A0445320
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 11 Jul 2020 00:08:55 +0300 (MSK)
References: <20200710075605.217824-1-gorcunov@gmail.com>
 <20200710075605.217824-3-gorcunov@gmail.com>
 <5040e7f2-6222-98d2-f058-4b2e903e758d@tarantool.org>
 <72595d93-b6d2-d97d-4270-e3d3e51a1275@tarantool.org>
 <20200710210710.GH1999@grain>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <3f9bd3e7-eb25-ab75-3a41-ec33b324a7c4@tarantool.org>
Date: Fri, 10 Jul 2020 23:08:54 +0200
MIME-Version: 1.0
In-Reply-To: <20200710210710.GH1999@grain>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH 2/5] qsync: add a comment about sync
 txn in journal allocation
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

On 10/07/2020 23:07, Cyrill Gorcunov wrote:
> On Fri, Jul 10, 2020 at 10:34:27PM +0200, Vladislav Shpilevoy wrote:
>> Не, сори, все ок. Коммент норм. Я уже не соображаю. Но
>> замечание про свормы мелких изменений все еще справедливо.
> 
> The main reason for small changes is for easier merging, iirc you
> were fixing some code and I didn't want to tie-up with the changes,
> making potential merge conflict easier to resolve.

You are missing the point. The problem is not in the commit size. It
is in it being unnecessary.