From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8ED446F3C7; Fri, 26 Mar 2021 22:46:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8ED446F3C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616787962; bh=fmcdYeYG7YWlE4d89HgXKGwGP4LXj8zbdqC/Uf1o1SE=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=DiEovtAvIhpLXIS1uGbAaAYMWLd2YHamn4ijxsFwEXkj38OU9yHJeAwL1kGJxupnE TLV+5sxnM79Jp4trO4GUGl4o4z8+gx+7XL4hF4cdP2IuQ1RLbn20bn3ZvrD3nh46yU 35+9CuaMeznj+R0rSzN66hJw5XyBxm6CC3wqfwkc= Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AF91E6F3C7 for ; Fri, 26 Mar 2021 22:45:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AF91E6F3C7 Received: by smtp40.i.mail.ru with esmtpa (envelope-from ) id 1lPsOh-0005Up-9g; Fri, 26 Mar 2021 22:45:31 +0300 To: Cyrill Gorcunov , tml References: <20210326120605.2160131-1-gorcunov@gmail.com> <20210326120605.2160131-3-gorcunov@gmail.com> Message-ID: <3f7f9386-6e0d-2cd7-60fa-8c227a052740@tarantool.org> Date: Fri, 26 Mar 2021 20:45:30 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210326120605.2160131-3-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947287414FD1D04A09E656A5F3377C994A182A05F538085040869D4D21B8C0A8F6A47F81043ACD5A5607782AFE1C7A10EFD0053395B5E4B577 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A929372354A9ECCCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063764345650F0BBEB0B8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C5DD32608FC869F5DE9300A049384CF3A973D15C0D9E086CEA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C34C82C86BFC697D19117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF1BD1948763FFC2C2BA3038C0950A5D36C8A9BA7A39EFB766EC990983EF5C0329BA3038C0950A5D36D5E8D9A59859A8B63BD8BFB0F436B6B276E601842F6C81A1F004C906525384307823802FF610243DF43C7A68FF6260569E8FC8737B5C2249B372FE9A2E580EFC725E5C173C3A84C3C9BE88FFEDFA497A35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2368A440D3B0F6089093C9A16E5BC824AC8B6CDF511875BC4E8F7B195E1C978312A66D9CA13B7FAA32240D5316989BD39 X-C1DE0DAB: 0D63561A33F958A53BE7E151879E755C2D5051597A24B068255639A9CEAB416ED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A541DB4061E9383296B85CC82E93E86778D96BF4A903359BA7C57D86CE1D0F2A446A65F47821FD261D7E09C32AA3244CF83F4EACFC28B733C50FAA3A05CDB67D7C0C08F7987826B9729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojapPp7P/VpAi3Im7drK857g== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA3110125A87AEA67769C43AC3A1442BBA53896CDAAAF1CD4B0D7707784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v5 2/3] test: add a test for wal_cleanup_delay option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! See 2 comments below. > --- /dev/null > +++ b/test/replication/gh-5806-xlog-cleanup.result > @@ -0,0 +1,435 @@ > +-- test-run result file version 2 > +-- > +-- gh-5806: defer xlog cleanup to keep xlogs until > +-- replicas present in "_cluster" are connected. > +-- Otherwise we are getting XlogGapError since > +-- master might go far forward from replica and > +-- replica won't be able to connect without full > +-- rebootstrap. > +-- > + > +fiber = require('fiber') > + | --- > + | ... > +test_run = require('test_run').new() > + | --- > + | ... > +engine = test_run:get_cfg('engine') > + | --- > + | ... > + > +-- > +-- Case 1. > +-- > +-- First lets make sure we're getting XlogGapError in > +-- case if wal_cleanup_delay is not used. > +-- > + > +test_run:cmd('create server master with script="replication/gh-5806-master.lua"') > + | --- > + | - true > + | ... > +test_run:cmd('start server master with wait=True, wait_load=True') 1. Both wait and wait_load are True by default. You don't need to specify them. Here and in other places where you made them True. > + | --- > + | - true > + | ... > +-- > +-- > +-- Case 3: Fill _cluster with replica but then delete > +-- the replica so that master's cleanup leave in "paused" > +-- state, and then simply decrease the timeout to make > +-- cleanup fiber work again. 2. Would also be good to have a test where GC is paused, but then the replica is deleted from _cluster (so gc unref is called) and gc continues.