From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 7423C29F52 for ; Mon, 1 Apr 2019 06:27:04 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MLRhK0eCaQ_P for ; Mon, 1 Apr 2019 06:27:04 -0400 (EDT) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2A89A29C50 for ; Mon, 1 Apr 2019 06:27:04 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: parameter binding for box.execute() From: Vladislav Shpilevoy References: <884040abe819e8ec11f7877d15e5482d6a24139b.1553947026.git.imeevma@gmail.com> <20190401052112.GB8239@chai> <648b0ae4-35e0-9df0-1a67-712788727b79@tarantool.org> Message-ID: <3f73a24c-f50c-bff8-8f20-bd8b6fcaf27f@tarantool.org> Date: Mon, 1 Apr 2019 13:27:00 +0300 MIME-Version: 1.0 In-Reply-To: <648b0ae4-35e0-9df0-1a67-712788727b79@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Konstantin Osipov , tarantool-patches@freelists.org Kirill S. said, that he has a patch moving binds and some other declarations into execute.h. It could help a bit, probably. But the question is the same. Should we do that now? On 01/04/2019 11:44, Vladislav Shpilevoy wrote: > > > On 01/04/2019 08:21, Konstantin Osipov wrote: >> * imeevma@tarantool.org [19/03/30 16:50]: >>> This patch defines parameters binding for SQL statements executed >>> through box.execute(). >> >> Could the dependency on lua_* be moved into src/box/lua/ or that >> would be difficult to do? > > It requires exposure of struct sql_bind into the header file, and > include "execute.h" into one of box/lua files. If you insist, we > can do that. Should we? > >> >> >> -- >> Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 >> http://tarantool.io - www.twitter.com/kostja_osipov >> >