From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B354D469710
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 29 May 2020 13:00:54 +0300 (MSK)
References: <20200528100738.221911-1-gorcunov@gmail.com>
 <20200528100738.221911-8-gorcunov@gmail.com>
 <19d91eba-a988-0ee8-6c1b-1b83dca9fce8@tarantool.org>
 <51ab9c83-4392-b5bd-49ac-652b1892afa0@tarantool.org>
 <68d0aeab-2db7-b552-ec0d-4bc64de792e1@tarantool.org>
 <20200529094944.GH215590@grain>
From: Oleg Babin <olegrok@tarantool.org>
Message-ID: <3f1a9b7d-7a2d-86ca-b417-b01e572099e1@tarantool.org>
Date: Fri, 29 May 2020 13:00:53 +0300
MIME-Version: 1.0
In-Reply-To: <20200529094944.GH215590@grain>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v4 7/8] lua/log: allow to configure
 logging without a box
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>, Leonid Vasiliev <lvasiliev@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

I completely agree with you.
We shouldn't overcomplicate code for such simple goal.

On 29/05/2020 12:49, Cyrill Gorcunov wrote:
> On Fri, May 29, 2020 at 12:16:08PM +0300, Leonid Vasiliev wrote:
>> Hi!
>> Maybe we need to apply something like the "observer" pattern.
>> When changes in "log" occur, it alerts subscribers.
> 
> Seriously, guys, I'm not going to bring some watchdog here,
> at least in this series 'cause it become over the bounds already.
> 
> I agree that we need a general solution with proper notification
> queues and etc but lets postpone it for better times. I think
> box_api interface is enough for now. It might be not that elegant
> as it could though. After all we will be able to easily extend it
> on top.
> 
> I'm preparing the v5 now and will try to address all your comments.
> At least most of them :-)
>