From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C5D715C052F; Thu, 17 Aug 2023 11:57:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C5D715C052F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692262671; bh=1bFDjXKz/SekfEQsXY7Pmt+hB+rOlG7/eIvsoJXxBHs=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=c1IHm2Rlp0kKk7J6IHh7B9xOcSTsWWKSU27rsLux95epxm9lKX3AjiUO7YRLlGI3f gHLrbuK0NSo4D9TWJEH51xyOBYeWqA/qGVcimxWb3IqzxNt95iyKhD8hktfJklNL+h JmTSm4iRhfdMNSfXlRCKf2DZeMYaSod+4xqZ0HIw= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 02286581FDB for ; Thu, 17 Aug 2023 11:57:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 02286581FDB Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1qWYpC-00074a-BD; Thu, 17 Aug 2023 11:57:50 +0300 Message-ID: <3e790e17-5ded-48ff-9716-4c32ed5dcdab@tarantool.org> Date: Thu, 17 Aug 2023 11:57:49 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Sergey Kaplun , Igor Munkin Cc: tarantool-patches@dev.tarantool.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD93AA62145E837FE28E96D0DBF739299FC3DB55B78047F7EFC182A05F5380850404C228DA9ACA6FE27C479607F229CA23239457A6E15C9E6D2ECB5286548B015927166C0EA46F0FF2A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73B44982FA5E78411EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B28E90C11C329EF18638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8DC4D0AC6034AA382A924AD93F69D8222117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC79B25E177BEFA2CBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18F04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8B974A882099E279BDAAAE862A0553A39223F8577A6DFFEA7C0B02670E5FEECA50C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A51CE67758AA3B611463D60D663756A3F85E605E94419CD531F87CCE6106E1FC07E67D4AC08A07B9B0735DFC8FA7AC1207CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34A2EC120135420F90848930AE807B2AC35B034A4FA627CDF3D28EC93484889BF9D615DDE982B962C31D7E09C32AA3244CB05DAE282B29631012436983F49B5093725D5B54B2FE457585A42E4C463514DC5DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojFRrmMqSMPxrdxUY4KWz27g== X-DA7885C5: 7EC9ECE7BF056E3090F9AAE4CE3E52841B52599D7B4BE8B71CE8A71E1A5FF309262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B550EB55D84BE8C14F3F7A47BA1C752E9DD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 15/19] Fix LJ_MAX_JSLOTS assertion in rec_check_slots(). X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! On 8/9/23 18:36, Sergey Kaplun wrote: > From: Mike Pall > > Thanks to Yichun Zhang. > > (cherry-picked from commit 1c89933f129dde76944336c6bfd05297b8d67730) > > This patch is predecessor for the commit > 944d32afd6ddd9dbac1cddf64bf81333efeb9e30 ("Add missing LJ_MAX_JSLOTS > check.") It tries to fix the issue, when `J->baseslot == LJ_MAX_JSLOTS`, > that leading to the assertion failure. Since the predecessor patch, > there are no places, that can lead to the condition failure, since we > always check that new baseslot + framesize (+ vargframe) >= > `LJ_MAX_JSLOTS`. As far as minimum framesize is 1 (see > for details), we can't obtain this assertion failure. This patch is > added for the consistency with the upstream. > > Since the predecessor patch fixes the issue, there is no new test case > to add. > > Sergey Kaplun: > * added the description for the problem Test for backported patch is missing. Why? > > Part of tarantool/tarantool#8825