From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp1.mail.ru (smtp1.mail.ru [94.100.179.111])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 43F984696C3
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 11 Apr 2020 17:34:34 +0300 (MSK)
References: <81e5cba334c04467e28948a491bd95d38f0d08ae.1585824116.git.imeevma@gmail.com>
 <81e5efe8-1627-6294-73bf-77db32e68e5a@tarantool.org>
 <20200410094923.GA6005@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <3e238eaa-82e1-c5d0-1a58-0cf2c49a66f7@tarantool.org>
Date: Sat, 11 Apr 2020 16:34:31 +0200
MIME-Version: 1.0
In-Reply-To: <20200410094923.GA6005@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v2 1/1] sql: do not change order of
	inserted values
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Mergen Imeev <imeevma@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the answers!

> --- a/src/box/sql/vdbe.c
> +++ b/src/box/sql/vdbe.c
> @@ -2694,23 +2694,10 @@ case OP_Column: {
>  		pC->cacheStatus = p->cacheCtr;
>  	}
>  	enum field_type field_type = field_type_MAX;
> -	if (pC->eCurType == CURTYPE_TARANTOOL) {
> -		/*
> -		 * Ephemeral spaces feature only one index
> -		 * covering all fields, but ephemeral spaces
> -		 * lack format. So, we can fetch type from
> -		 * key parts.
> -		 */
> -		if (pC->uc.pCursor->curFlags & BTCF_TEphemCursor) {
> -			field_type = pC->uc.pCursor->index->def->
> -					key_def->parts[p2].type;
> -		} else if (pC->uc.pCursor->curFlags & BTCF_TaCursor) {
> -			field_type = pC->uc.pCursor->space->def->
> -					fields[p2].type;
> -		}
> -	} else if (pC->eCurType == CURTYPE_SORTER) {
> +	if (pC->eCurType == CURTYPE_TARANTOOL)
> +		field_type = pC->uc.pCursor->space->def->fields[p2].type;
> +	else if (pC->eCurType == CURTYPE_SORTER)
>  		field_type = vdbe_sorter_get_field_type(pC->uc.pSorter, p2);
> -	}
>  	struct Mem *default_val_mem =
>  		pOp->p4type == P4_MEM ? pOp->p4.pMem : NULL;
>  	if (vdbe_field_ref_fetch(&pC->field_ref, p2, pDest) != 0)

Shouldn't this be a part of the previous commit, which
introduces the ephemeral space format?