From: Aleksandr Lyapunov <alyapunov@tarantool.org>
To: Oleg Babin <olegrok@tarantool.org>, tarantool-patches@dev.tarantool.org
Cc: alexander.turenko@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] Formatted select in lua console
Date: Mon, 13 Jul 2020 11:52:05 +0300 [thread overview]
Message-ID: <3dff6ba1-f43e-c6bf-d72b-e45cd364f5cf@tarantool.org> (raw)
In-Reply-To: <37453fed-c16b-5644-b9ff-31373c64ca18@tarantool.org>
Hello, thanks for comments!
Honestly speaking I didn't know about "lua output". As I see event
"\help" is broken in lua output too )
As I understood lua output escapes almost all whitespaces and that's why
is not suitable for formatting.
I'm not sure that it's possible to canonically catch output method in
lua console. But if we could - we should not prohibit usage of fselect -
it's still good for printing (via print() ), logging etc.
On 10.07.2020 18:37, Oleg Babin wrote:
> Hi! Thanks for your patch!
>
> It's not a review, but I just tried to use it. Works fine for default
> yaml console. But seems it completely broken for lua output.
>
prev parent reply other threads:[~2020-07-13 8:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 10:03 Aleksandr Lyapunov
2020-07-10 10:03 ` [Tarantool-patches] [PATCH] Introduce fselect - formatted select Aleksandr Lyapunov
2020-09-14 19:02 ` Alexander Turenko
2020-07-10 10:08 ` [Tarantool-patches] [PATCH] Formatted select in lua console Aleksandr Lyapunov
2020-07-10 15:37 ` Oleg Babin
2020-07-13 8:52 ` Aleksandr Lyapunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dff6ba1-f43e-c6bf-d72b-e45cd364f5cf@tarantool.org \
--to=alyapunov@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=olegrok@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] Formatted select in lua console' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox