From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 206AA257F4
	for <tarantool-patches@freelists.org>; Thu, 17 Jan 2019 08:15:44 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id pxQ_EMXaGuek for <tarantool-patches@freelists.org>;
	Thu, 17 Jan 2019 08:15:44 -0500 (EST)
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 5F44822714
	for <tarantool-patches@freelists.org>; Thu, 17 Jan 2019 08:15:43 -0500 (EST)
Subject: [tarantool-patches] Re: [PATCH v7 1/6] lua: remove exceptions
 from function luaL_tofield()
References: <cover.1547565887.git.imeevma@gmail.com>
 <c2014b6203734ef0541f00cbd4dcfddf40df248f.1547565887.git.imeevma@gmail.com>
 <20190117113800.GJ28204@chai>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <3cfde813-ddb4-cbb7-34b5-6132c5ea1c94@tarantool.org>
Date: Thu, 17 Jan 2019 16:15:31 +0300
MIME-Version: 1.0
In-Reply-To: <20190117113800.GJ28204@chai>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Konstantin Osipov <kostja@tarantool.org>, tarantool-patches@freelists.org



On 17/01/2019 14:38, Konstantin Osipov wrote:
> * imeevma@tarantool.org <imeevma@tarantool.org> [19/01/15 19:14]:
>> Before this commit, the luaL_tofield() function threw a Lua
>> diff --git a/src/lua/utils.c b/src/lua/utils.c
>> index 978fe61..9a9fd3a 100644
>> --- a/src/lua/utils.c
>> +++ b/src/lua/utils.c
>> @@ -37,6 +37,8 @@
>>   #include <diag.h>
>>   #include <fiber.h>
>>   
>> +#include "box/error.h"
> 
> Please don't. This violates encapsulation.
> 
> 

Oh, of course. Sorry, dismissed it. Mergen, we can not
use ClientError outside of box/ module. See exception.h for
available errors. I think, LuajitError is the most suitable
here.