From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 85E53469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 22 Sep 2020 11:47:56 +0300 (MSK)
References: <cover.1599693319.git.v.shpilevoy@tarantool.org>
 <17979db071a67d8e5f299fd405095dc14a507b3c.1599693319.git.v.shpilevoy@tarantool.org>
 <df4211eb-7e73-dd0a-4a46-843bcf54c96e@tarantool.org>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <3cee7cbe-5933-7d34-4146-e75ba69e9cb8@tarantool.org>
Date: Tue, 22 Sep 2020 11:47:53 +0300
MIME-Version: 1.0
In-Reply-To: <df4211eb-7e73-dd0a-4a46-843bcf54c96e@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: ru
Subject: Re: [Tarantool-patches] [PATCH v2 08/11] raft: relay status updates
 to followers
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org, gorcunov@gmail.com


22.09.2020 01:47, Vladislav Shpilevoy пишет:
>> diff --git a/src/box/applier.cc b/src/box/applier.cc
>> index c1d07ca54..ed76bf2ca 100644
>> --- a/src/box/applier.cc
>> +++ b/src/box/applier.cc
>> @@ -298,6 +299,8 @@ apply_final_join_row(struct xrow_header *row)
>>   	 */
>>   	if (iproto_type_is_synchro_request(row->type))
>>   		return 0;
>> +	if (iproto_type_is_raft_request(row->type))
>> +		return 0;
> It seems we can drop this check, can't we? Because now relay sends raft
> messages only during subscribe phase.
Yep, looks  like so
>>   	struct txn *txn = txn_begin();
>>   	if (txn == NULL)
>>   		return -1;

-- 
Serge Petrenko