From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>,
Sergey Bronnikov <estetus@gmail.com>
Cc: tarantool-patches@dev.tarantool.org, max.kokryashkin@gmail.com
Subject: Re: [Tarantool-patches] [PATCH luajit 1/3][v2] Add 'cc' file type for saving bytecode.
Date: Wed, 15 Nov 2023 12:39:58 +0300 [thread overview]
Message-ID: <3ce65ea6-59dd-4c2d-9add-5e1edd91d861@tarantool.org> (raw)
In-Reply-To: <ZVHKcATuOFwP_iCJ@root>
Hello, Sergey
commit message updated and force-pushed.
Sergey
On 11/13/23 10:04, Sergey Kaplun via Tarantool-patches wrote:
> Hi, Sergey!
> Thanks for the patch.
> LGTM, after fixing my nits below.
>
> On 09.11.23, Sergey Bronnikov wrote:
>> From: Mike Pall <mike>
>>
>> Contributed by Sergey Bronnikov. #1105
> Minor: I suggest dropping #1105 here to avoid spamming to the ticket
> during development.
Fixed.
>
>> (cherry picked from commit e826d0c101d750fac8334d71e221c50d8dbe236c)
>>
>> The patch adds a file type `cc` that allows exporting byte code directly
>> to a file with extension `.cc`.
> Typo: s/extension/the extension/
Fixed.
>
> I suppose it is worth mentioning that the test will be added within
> future commits?
Added.
>
>> Sergey Bronnikov:
>> * added the description
>>
>> Part of tarantool/tarantool#9145
>> ---
> <snipped>
>
next prev parent reply other threads:[~2023-11-15 9:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 13:06 [Tarantool-patches] [PATCH luajit 0/3][v2] Fix C file generation in jit.bcsave Sergey Bronnikov via Tarantool-patches
2023-11-09 13:08 ` [Tarantool-patches] [PATCH luajit 1/3][v2] Add 'cc' file type for saving bytecode Sergey Bronnikov via Tarantool-patches
2023-11-13 7:04 ` Sergey Kaplun via Tarantool-patches
2023-11-15 9:39 ` Sergey Bronnikov via Tarantool-patches [this message]
2023-11-09 13:08 ` [Tarantool-patches] [PATCH luajit 2/3][v2] test: set dependencies to tarantool-tests explicitly Sergey Bronnikov via Tarantool-patches
2023-11-13 7:10 ` Sergey Kaplun via Tarantool-patches
2023-11-15 11:34 ` Sergey Bronnikov via Tarantool-patches
2023-11-09 13:08 ` [Tarantool-patches] [PATCH luajit 3/3][v2] Fix C file generation in jit.bcsave Sergey Bronnikov via Tarantool-patches
2023-11-13 7:10 ` Sergey Kaplun via Tarantool-patches
2024-02-29 7:40 ` [Tarantool-patches] [PATCH luajit 0/3][v2] " Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ce65ea6-59dd-4c2d-9add-5e1edd91d861@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=estetus@gmail.com \
--cc=max.kokryashkin@gmail.com \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 1/3][v2] Add '\''cc'\'' file type for saving bytecode.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox