From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4FD3B4C889; Thu, 14 Jan 2021 12:10:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4FD3B4C889 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1610615430; bh=BAnk7D32xnvsLzK4mSYNJShu2lqxO3quOL3y8ZlE2pA=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=VQg+bq+826De3oE1Pqe7k0hk5Ryy4vwyeaRpigEtpjY70/mjMSRXiHRHROocZiywU RXt1QkaasKwgqjcgiltAZ3dPvNP+6YR7bkjceIUMJl6hFGPhSFkpfmJlI0ScwSjgjm KXmSXaApUaGRNZ2GWhuTEprzFxaoSEqW4zxNKVG8= Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AE80C4C885 for ; Thu, 14 Jan 2021 12:10:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AE80C4C885 Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1kzyeD-0000rW-4g; Thu, 14 Jan 2021 12:10:29 +0300 To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org Cc: alexander.turenko@tarantool.org References: Message-ID: <3caccc71-ff3c-29ea-a857-b36949f55a89@tarantool.org> Date: Thu, 14 Jan 2021 12:10:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D0E79FBC973162CD9B382B274FF537389656BC690FF7BBE200894C459B0CD1B9F5720786ECC62AB3D40A1AA3EFDAEC0E1941F1756450D259479AC59D1825621F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE763424119D34F5CBFEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378D071468F2F69688EA1F7E6F0F101C674E70A05D1297E1BBC6CDE5D1141D2B1C4033B042C5255295C784ECF5C0E1F79FF96237955A2076479FA2833FD35BB23D9E625A9149C048EE33AC447995A7AD18C26CFBAC0749D213D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B3A703B70628EAD7BA471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FC9C0EFA9084E6D3E03AA81AA40904B5D9CF19DD082D7633A078D18283394535A93AA81AA40904B5D98AA50765F790063701548D89DD978D79D81D268191BDAD3D698AB9A7B718F8C442539A7722CA490C13377AFFFEAFD26923F8577A6DFFEA7CE52E467C461EF0E993EC92FD9297F6715571747095F342E857739F23D657EF2BD5E8D9A59859A8B66106518975EE654D089D37D7C0E48F6C5571747095F342E857739F23D657EF2B6825BDBE14D8E7028C9DFF55498CEFB0BD9CCCA9EDD067B1EDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A592D119D75235861D3313897124ECC982DA6276C53346E7E3D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA758F9E841AEAEC4F2C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D346C409ABC5F9C579B2716312E1292245F27B98E787BE49C3C433A826F105C1E83517C7886E21EB6941D7E09C32AA3244CA673BEEB4476873783E201077A167BCB7C0C08F7987826B9FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj9kdO2HH36x7Qf6nMO/BEPw== X-Mailru-Sender: 48EFD2E18A91C559803250E574CC3D294583BFEBFE2310B4D4E0535C8CF20D0C9BBFB9D4C9B76856D35D514C7DAC97282D063C67CFD4E84987597EC79699C0E6F21BD4036121A32F7402F9BA4338D657ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 4/4] test: enable disabled testcases back X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Leonid Vasiliev via Tarantool-patches Reply-To: Leonid Vasiliev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thank you for the patch. LGTM. On 13.01.2021 11:48, sergeyb@tarantool.org wrote: > From: Sergey Bronnikov > > In a commit "httpc: temporary disable redirecting test case" > (4cc6978ae7be7dc3785a52c064b07850582522de) a set of testcases > has been disabled while the bug #4180 is open. > Right now bug is closed so it is a time to enable testcases back. > --- > test/app-tap/http_client.test.lua | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/test/app-tap/http_client.test.lua b/test/app-tap/http_client.test.lua > index 093af8fe4..aafad0004 100755 > --- a/test/app-tap/http_client.test.lua > +++ b/test/app-tap/http_client.test.lua > @@ -62,7 +62,7 @@ local function stop_server(test, server) > end > > local function test_http_client(test, url, opts) > - test:plan(11) > + test:plan(12) > > -- gh-4136: confusing httpc usage error message > local ok, err = pcall(client.request, client) > @@ -85,9 +85,6 @@ local function test_http_client(test, url, opts) > local r = client.request('GET', url, nil, opts) > test:is(r.status, 200, 'request') > > - -- XXX: enable after resolving of gh-4180: httpc: redirects > - -- are broken with libcurl-7.30 and older > - --[[ > -- gh-4119: specify whether to follow 'Location' header > test:test('gh-4119: follow location', function(test) > test:plan(7) > @@ -111,7 +108,6 @@ local function test_http_client(test, url, opts) > test:is(r.body, 'redirecting', 'do not follow location: body') > test:is(r.headers['location'], '/', 'do not follow location: header') > end) > - ]]-- > end > > -- >