From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [tarantool-patches] Re: [PATCH 0/2] uri: fixups after move to lib References: <917b4c01-9906-44b7-6e16-2253fdef800f@tarantool.org> <20190227154829.ptdegrscv75frwkd@tkn_work_nb> From: Vladislav Shpilevoy Message-ID: <3bc9b8a8-956a-d2c6-9deb-d82be54ee40f@tarantool.org> Date: Wed, 27 Feb 2019 18:54:33 +0300 MIME-Version: 1.0 In-Reply-To: <20190227154829.ptdegrscv75frwkd@tkn_work_nb> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit To: Alexander Turenko Cc: tarantool-patches@freelists.org, Vladimir Davydov List-ID: Thanks, LGTM. On 27/02/2019 18:48, Alexander Turenko wrote: > I also added test-run update to fix app-tap/http_client.test.lua. It is > not related to uri.c moving, but I cannot test this patchset without > that fix. Hope it is okay to not being too formal and propose it as part > of this patchset. > > The description is the following. The commit contains only test-run > update. > > commit 4e4846df761573d04c914cf0669eb1cb490f4df7 > Author: Alexander Turenko > Date: Wed Feb 27 18:35:58 2019 +0300 > > test: update test-run > > * Added basic luacov support. > * Added use_unix_sockets_iproto option. > * Fixed TARANTOOL_SRC_DIR on >=tarantool-2.1.1-322-g3f5f59bb5. > - It is important for app-tap/http_client.test.lua, it fails now. > * Renamed pre_cleanup to pretest_clean. > * pretest_clean: clean up _cluster space. > > Now all should be good, awaiting for travis: > > https://travis-ci.org/tarantool/tarantool/builds/499340382 > > WBR, Alexander Turenko. > > On Wed, Feb 27, 2019 at 05:29:17PM +0300, Vladislav Shpilevoy wrote: >> Thanks for the hotfix of my broken commit! >> >> The patchset almost LGTM, except for reference to >> the problematic issue - usually we do not paste the >> whole commit message and meta. We just write something >> like that: >> >> " >> The bug was introduced by d735b6bfb18ed5cdaa020f247326dfcfd72d47b4: >> Move 'uri' lib to src/lib/ >> " >> >> When you copypaste the whole commit meta, you accidentally >> catch also issue references like 'Needed for #3234', despite >> the fact, that this fix is not needed for the issue. > > It is maybe good property: a fixup of an issue fix is related to the > issue. But anyway I changed the commit message to fit our style. > >> >> Please, fix the commit links, and then LGTM. >> >> Thanks again. Shame on me. >> >> On 27/02/2019 14:17, Alexander Turenko wrote: >>> no issue >>> https://github.com/tarantool/tarantool/tree/Totktonada/uri-c-move-fixups >>> https://travis-ci.org/tarantool/tarantool/builds/499212106 (in progress >>> now) >>> >>> Changes: >>> >>> * Fixed lcov / coveralls-lcov errors. >>> * Fixed `make ragel` command. >>> >>> This is follow up of the following commit: >>> >>> commit d735b6bfb18ed5cdaa020f247326dfcfd72d47b4 >>> Author: Vladislav Shpilevoy >>> Date: Mon Feb 25 18:21:36 2019 +0300 >>> >>> Move 'uri' lib to src/lib/ >>> URI and core libraries are going to be used by SWIM, stored in >>> src/lib. But src/lib can not depend on src/. This patch pushes >>> URI library down to src/lib - the lowest level of source >>> dependencies. >>> Needed for #3234 >>> >>> Warnings / error examples: >>> >>> * https://travis-ci.org/tarantool/tarantool/jobs/498692663#L3741 >>> * https://travis-ci.org/tarantool/tarantool/jobs/498692663#L4197 >>> >>> Alexander Turenko (2): >>> uri: fix uri.c debug info for lcov >>> uri: fix uri.c generation command (make ragel) >>> >>> src/lib/uri/CMakeLists.txt | 2 +- >>> src/lib/uri/uri.c | 550 ++++++++++++++++++------------------- >>> 2 files changed, 276 insertions(+), 276 deletions(-) >>> >>> -- >>> 2.20.1 >>> >>>