From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 92E6E1A2AD49; Tue, 10 Mar 2026 17:19:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 92E6E1A2AD49 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1773152388; bh=uUWYNb10DQh9NH7rcRAColoYMNDf5DzNP22z3ioJZ00=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=UyGhovQH2uMCOuC/E+DaYaJ6RH0ExlthiNXzQhXm+/BtuVVXxmndJKI4z0kuVW/7h /VSc6r390yRujrdBUdoHWHX/4b+CVnd1vmi7OKwVRJeJwfKReeeTq7PWq07+Lnmgml KdVEDJSMxNVYwqie80C69jvNBc86DxDiosm3x0go= Received: from send57.i.mail.ru (send57.i.mail.ru [89.221.237.152]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2F3BA39804F for ; Tue, 10 Mar 2026 17:19:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2F3BA39804F Received: by exim-smtp-695fc89d9f-bjxqd with esmtpa (envelope-from ) id 1vzxw2-000000000Zh-0Pez; Tue, 10 Mar 2026 17:19:46 +0300 Content-Type: multipart/alternative; boundary="------------80HkAelFfToP0b2mZ3r3oUcr" Message-ID: <3bc1b0da-6c28-46a9-8f69-2a27cce60088@tarantool.org> Date: Tue, 10 Mar 2026 17:19:45 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <20260225121140.18847-1-skaplun@tarantool.org> <0aee43fd-f0a6-410b-b67b-10461724a66f@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91ABAE9865AC7DC8818B4CD52367FE98173B6651699D6E8DA182A05F538085040DAAEC2217167AFDD3DE06ABAFEAF6705361AC68791CD129323EB4DE9956549DD59F445DFCDA6A35E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BF6699A3AA9BACA6EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB553375665A08EF23E7B416ABA682F4E8D8F20E62A2438568FFCB72F52DFC36FB8BA40846389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B64854413538E1713FCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE76D0F27F7E6A6C418731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A50593C3CDFF8B97475002B1117B3ED69616C874DD52DBD24AF5FEB6EB1EB183FD823CB91A9FED034534781492E4B8EEAD2B25D9E4C92BC8ACBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D65902984D72254584D5302254600524C8108B712B6F373931759BA862F67E54CF242EADDE6FE4A8C7D2B8341EE9D5BE9A0A914E9849F8BE63C7FCBE63D1AD1B4C3C017295270B4B83088CD93680B12512CF4C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVdbVVJCphTR/28LdS6mppfE= X-DA7885C5: 84FA86F321E47292F255D290C0D534F941B34AD7AC4D09BC9B87CF2182471044E90A69C383E3DE105B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393DDD5FD59B456EAD277086D03F71D37AFD6E7007748DEF23C9FD87331B9F87AD2EF86D5F70DA33880E41E8EF7A07863ECB274557F927329BE2DDF8182D28ACDB545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Prevent snapshot purge while recording a function header. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------80HkAelFfToP0b2mZ3r3oUcr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey! On 3/3/26 15:01, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > See my answer below. > > On 03.03.26, Sergey Bronnikov wrote: >> Hi, Sergey, >> >> thanks for the patch! LGTM with a minor comment. >> >> Sergey >> >> On 2/25/26 15:11, Sergey Kaplun wrote: > > >>> + >>> +local checkers = {} >>> + >>> +-- Called twice for the pseudo-type that aliases base Lua type via >>> +-- checkers map. >>> +local function checks(expected_type) >>> + -- Value expected to be `checks_tab()` or `checks_obj()` >>> + -- argument. It is always a table. >>> + local _, value = debug_getlocal(2, 1) >>> + -- Simple stitching function. Additional arguments are needed to >>> + -- occupy the corresponding slot. >> It is not clear for me why this corresponding slot is needed. >> >> The bug can be reproduced without double nil's passed to math_modf(). > Not for all builds (i.e. GC64 and non-GC64). ok, thanks for the answer! LGTM then --------------80HkAelFfToP0b2mZ3r3oUcr Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey!

On 3/3/26 15:01, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review!
See my answer below.

On 03.03.26, Sergey Bronnikov wrote:

Hi, Sergey,

thanks for the patch! LGTM with a minor comment.

Sergey

On 2/25/26 15:11, Sergey Kaplun wrote:

<snipped>


+
+local checkers = {}
+
+-- Called twice for the pseudo-type that aliases base Lua type via
+-- checkers map.
+local function checks(expected_type)
+  -- Value expected to be `checks_tab()` or `checks_obj()`
+  -- argument. It is always a table.
+  local _, value = debug_getlocal(2, 1)
+  -- Simple stitching function. Additional arguments are needed to
+  -- occupy the corresponding slot.

It is not clear for me why this corresponding slot is needed.

The bug can be reproduced without double nil's passed to math_modf().

Not for all builds (i.e. GC64 and non-GC64).

ok, thanks for the answer!

LGTM then


<snipped>

--------------80HkAelFfToP0b2mZ3r3oUcr--