From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0C0636EC63; Sat, 10 Apr 2021 00:53:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0C0636EC63 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618005222; bh=zEjbpa2OPcB12+wtpk/09WCtXtYvqmyU7SLA0jIwmlo=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=BOtTB3POmRGsyap1fxJmOWjgZrFfpNqgMjF1gbfAReF9+noCQKM2SS2Em7hr1uy41 zdFgtRzNMW6+FB7dyjekwGeMxbobHg2H+dJ6yBMpdjF/AGThuIGajKMYYYcanOyV7Y ueaQFf9Hg6nGAQYLe8WA3ZrBVgMgbFDFid20d5ps= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 951726EC5B for ; Sat, 10 Apr 2021 00:53:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 951726EC5B Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lUz4M-0006K0-TA; Sat, 10 Apr 2021 00:53:39 +0300 To: Serge Petrenko , alexander.turenko@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <0feec24c50d302255a300e27678448577f30540b.1617888916.git.sergepetrenko@tarantool.org> Message-ID: <3b023576-0a64-9347-e2cb-f355d6bd9e94@tarantool.org> Date: Fri, 9 Apr 2021 23:53:37 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <0feec24c50d302255a300e27678448577f30540b.1617888916.git.sergepetrenko@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E74806859AC5FE18436AEED970E897805ADA4182A05F538085040A5491FD471C8EDC2D9F4C826A2327D747B229D9139CAC808A5273E4C4CDC1301 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74FC7AD0AD96C1577EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637C8BD49B17AF1FC7C8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B261097DB1B822AA04F90E20D50667EF0D267281413F282BCCD2E47CDBA5A96583C09775C1D3CA48CFED8438A78DFE0A9E117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE77A825AB47F0FC8649FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA73A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E7356C9A9530EBF72002C4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C978314BCD8676CF4A6AA1B59FADFEE23B5201 X-C1DE0DAB: 0D63561A33F958A5C1E37C4F6911F88363DD0BE588CEE237DBB71992F95ACC3BD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3467D08F30473A58421B7801381300D8E3BC9CB5E4C47360140C2ABD4155A200CBBF5CB2B5F89C6F691D7E09C32AA3244C55C52CAF0490AE151D62AA2AC4C30B6AA90944CA99CF22E3FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojqcJA+pXcDumQzaY8n+KcFw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382203A42894A19D5F429930833D1576E92B3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 3/5] feedback_daemon: send feedback on server start X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patchset! On 08.04.2021 15:38, Serge Petrenko via Tarantool-patches wrote: > Send the first report as soon as instance's initial configuration > finishes. > > Part of #5750 > --- > src/box/lua/feedback_daemon.lua | 10 ++++++++++ > src/box/lua/load_cfg.lua | 34 ++++++++++++++++++++++----------- > 2 files changed, 33 insertions(+), 11 deletions(-) > > diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua > index d00eedf39..43bbc1fa2 100644 > --- a/src/box/lua/feedback_daemon.lua > +++ b/src/box/lua/feedback_daemon.lua > @@ -323,6 +323,12 @@ local function fill_in_feedback(feedback) > return feedback > end > > +-- fixme: remove this hack. > +-- It's here to prevent too early feedback sending. > +-- This leads to problems with thread sanitization after fork() on Mac OS. > +-- Google objc_initializeAfterForkError for details. > +local is_first_send = true Have you tried this? https://stackoverflow.com/questions/50168647/multiprocessing-causes-python-to-crash-and-gives-an-error-may-have-been-in-progr We could add it to the CI jobs so the env variable would be set. And set it manually on our own machines. You can also use jit.os to start it without a delay on non-Mac machines. On Mac jit.os == 'OSX'. I see we use it in some places, so it looks legal and working.