From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 8E28C290DF
	for <tarantool-patches@freelists.org>; Tue, 28 Aug 2018 19:21:25 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 4NRSrFjlfP2i for <tarantool-patches@freelists.org>;
	Tue, 28 Aug 2018 19:21:25 -0400 (EDT)
Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id CD46128F9C
	for <tarantool-patches@freelists.org>; Tue, 28 Aug 2018 19:21:24 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v2 2/2] sql: remove struct Enc
References: <cover.1535367103.git.kshcherbatov@tarantool.org>
 <388a4c514161fb19233e3185e6f211d33fd7f7f3.1535367103.git.kshcherbatov@tarantool.org>
 <e1720d72-628d-23a0-99cd-a2a62e5fe19b@tarantool.org>
 <b88b085a-ef55-c9bf-f04e-568b117f351b@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <3ac248e9-a52f-7549-cdf6-024a4c48ea2a@tarantool.org>
Date: Tue, 28 Aug 2018 20:21:17 -0300
MIME-Version: 1.0
In-Reply-To: <b88b085a-ef55-c9bf-f04e-568b117f351b@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>, tarantool-patches@freelists.org
Cc: Kirill Yukhin <kyukhin@tarantool.org>

Thanks for the fixes! Now the whole patchset LGTM.

As I know, for Nikita as well, so Kirill Yu., look at
it, please.

>> 4. Finish a sentence with the dot. Btw the comment
>> is not related to the code. Below you do not whether
>> the index is unique or not.
>> 5. "Did't defined" - corrupted phrase. Rather "did't define".
>> But the whole comment looks strange as well as the previous,
>> and out of its place. Just remove it.
> You know, I've just copied existed peace of code with all comments.
> I've get rid off those two comments at all now.

I know, but it is not an excuse. After the patch was pushed, git blame
would show your name against these lines.