From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7931D6EC55; Thu, 29 Jul 2021 00:34:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7931D6EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627508085; bh=xVd5sZp0iF+fTVuSggXNXJVe1GHGkd/1BGLDa+QmLOk=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=qozbE5a80nEh8t3HakCH1yKSmkhwnJItoLYot8wABd3mDUz8x9HcEBfKn36BQqol0 dHiV1Njpm5kXeJYdZy81SnP7BzsnppCJIh9rFQu0UiQMGzydXFbQG/aubj7NRuDwRO CYbUgwMg/mv6zn/DFQ4BJiTSJKRYnqsnW4+gQ+8s= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D23B36EC55 for ; Thu, 29 Jul 2021 00:34:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D23B36EC55 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1m8rCO-0005z4-82; Thu, 29 Jul 2021 00:34:44 +0300 To: Cyrill Gorcunov , tml References: <20210726153452.113897-1-gorcunov@gmail.com> <20210726153452.113897-4-gorcunov@gmail.com> Message-ID: <3a64d0ce-b2aa-d331-942e-b60484638dd9@tarantool.org> Date: Wed, 28 Jul 2021 23:34:43 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210726153452.113897-4-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD941C43E597735A9C34755E0A9F196FCB739C645213AB7C8E0182A05F5380850403FD3CE4774591436DCB314D72D1EA38051FC5AC9F0E21326B509E47F02A14645 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75263010198C72082EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E0FC02D497BF09508638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D88121E30BF356EEDFE5CC7E0EEA6CFA75117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAE9A1BBD95851C5BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10FE5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A45692FFBBD75A6A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A51D9DF17B8A3354E343B8F4A7F5018F75E23C907482574E70D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA754263BA4E959D734C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34FD9114F69CA58D1E10288C198AA8436393C79D0C61FC7443D6492810D86EE6AC38B40B9BDBA6A8F41D7E09C32AA3244C36CFC6F15C6F7991797DC932D1E0692997FE24653F78E668729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPp/mPgZxawHWtz8Lw39rfA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D15DFF437B0774DAE7B48C5E592E05BCC3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v8 3/6] limbo: gather promote tracking into a separate structure X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! On 26.07.2021 17:34, Cyrill Gorcunov via Tarantool-patches wrote: > It is needed to introduce ordered promote related data > modifications in next patch. Why do you need this new struct? While I like the new names (the old promote_greatest_term was super long), I don't see any motivation to extract the members into a new struct. It is still used only inside of the limbo as a member. I suppose this might be a leftover from the old versions of the patchset. Please, try to keep these members inside of the limbo like they were.