From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <roman.habibov@tarantool.org>
Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C692040F3AE
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 12 Jun 2020 00:03:12 +0300 (MSK)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3594.4.19\))
From: Roman Khabibov <roman.habibov@tarantool.org>
In-Reply-To: <20200610140038.cakjpgjlo4hlkbut@tarantool.org>
Date: Fri, 12 Jun 2020 00:03:10 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <3B8C2D8B-C853-4C4D-85CB-9C3A79635226@tarantool.org>
References: <20200610124701.13055-1-roman.habibov@tarantool.org>
 <20200610140038.cakjpgjlo4hlkbut@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] sql: display collation in metadata
 for scalar
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the review.

@ChangeLog
- Fix bug with the display of collation for scalar fields in
<SELECT> result, when sql_full_metadata is enabled.

> On Jun 10, 2020, at 17:00, Kirill Yukhin <kyukhin@tarantool.org> =
wrote:
>=20
> Hello,
>=20
> Thanks for the patch. Few nits inlined.
>=20
> Where is ChangeLog entry?
Done.

> Fix it and it will be LGTM.
>=20
> On 10 =D0=B8=D1=8E=D0=BD 15:47, Roman Khabibov wrote:
>> Fix bug with the  display of collation for scalar fields in
>=20
> Double space.
Fixed.

>> <SELECT> result, when sql_full_metadata is enabled.
>>=20
>> Closes #4755
>> ---
>>=20
>> Branch: =
https://github.com/tarantool/tarantool/tree/romanhabibov/gh-4755-scalar-co=
llation
>> Issue: https://github.com/tarantool/tarantool/issues/4755
>>=20
>> src/box/sql/select.c                          |  7 +--
>> .../gh-4755-scalar-collation-metadata.result  | 52 =
+++++++++++++++++++
>> ...gh-4755-scalar-collation-metadata.test.lua | 18 +++++++
>> 3 files changed, 74 insertions(+), 3 deletions(-)
>> create mode 100644 test/sql/gh-4755-scalar-collation-metadata.result
>> create mode 100755 =
test/sql/gh-4755-scalar-collation-metadata.test.lua
>>=20
>> diff --git a/test/sql/gh-4755-scalar-collation-metadata.result =
b/test/sql/gh-4755-scalar-collation-metadata.result
>> new file mode 100644
>> index 000000000..eef2d86ad
>> --- /dev/null
>> +++ b/test/sql/gh-4755-scalar-collation-metadata.result
>> @@ -0,0 +1,52 @@
>> +-- test-run result file version 2
>> +env =3D require('test_run')
>> + | ---
>> + | ...
>> +test_run =3D env.new()
>> + | ---
>> + | ...
>> +
>> +--
>> +-- gh-4755: Collation in metadata must be displayed as for string
>> +-- filed as for scalar field.
>=20
> Start with lowercase, please. Re-phrase it: "... for both string and =
scalar field types =E2=80=A6=E2=80=9D
+-- gh-4755: collation in metadata must be displayed for both
+-- string and scalar field types.

> --
> Regards, Kirill Yukhin

commit 8e398297beb216e6267797a6b929513156f76f36
Author: Roman Khabibov <roman.habibov@tarantool.org>
Date:   Fri Apr 17 10:04:44 2020 +0300

    sql: display collation in metadata for scalar
   =20
    Fix bug with the display of collation for scalar fields in
    <SELECT> result, when sql_full_metadata is enabled.
   =20
    Closes #4755

diff --git a/src/box/sql/select.c b/src/box/sql/select.c
index f39484013..92d20e992 100644
--- a/src/box/sql/select.c
+++ b/src/box/sql/select.c
@@ -1792,9 +1792,10 @@ generate_column_metadata(struct Parse *pParse, =
struct SrcList *pTabList,
 			continue;
 		if (p->op =3D=3D TK_VARIABLE)
 			var_pos[var_count++] =3D i;
-		vdbe_metadata_set_col_type(v, i,
-					   =
field_type_strs[sql_expr_type(p)]);
-		if (is_full_meta && sql_expr_type(p) =3D=3D =
FIELD_TYPE_STRING) {
+		enum field_type type =3D sql_expr_type(p);
+		vdbe_metadata_set_col_type(v, i, field_type_strs[type]);
+		if (is_full_meta && (type =3D=3D FIELD_TYPE_STRING ||
+		    type =3D=3D FIELD_TYPE_SCALAR)) {
 			bool unused;
 			uint32_t id =3D 0;
 			struct coll *coll =3D NULL;
diff --git a/test/sql/gh-4755-scalar-collation-metadata.result =
b/test/sql/gh-4755-scalar-collation-metadata.result
new file mode 100644
index 000000000..cccc4aae8
--- /dev/null
+++ b/test/sql/gh-4755-scalar-collation-metadata.result
@@ -0,0 +1,52 @@
+-- test-run result file version 2
+env =3D require('test_run')
+ | ---
+ | ...
+test_run =3D env.new()
+ | ---
+ | ...
+
+--
+-- gh-4755: collation in metadata must be displayed for both
+-- string and scalar field types.
+--
+test_run:cmd("setopt delimiter ';'");
+ | ---
+ | - true
+ | ...
+box.execute([[SET SESSION "sql_full_metadata" =3D true;]]);
+ | ---
+ | - row_count: 1
+ | ...
+box.execute([[CREATE TABLE test (a SCALAR COLLATE "unicode_ci" PRIMARY =
KEY,
+                                 b STRING COLLATE "unicode_ci");]]);
+ | ---
+ | - row_count: 1
+ | ...
+box.execute("SELECT * FROM test;");
+ | ---
+ | - metadata:
+ |   - span: A
+ |     type: scalar
+ |     is_nullable: false
+ |     name: A
+ |     collation: unicode_ci
+ |   - span: B
+ |     type: string
+ |     is_nullable: true
+ |     name: B
+ |     collation: unicode_ci
+ |   rows: []
+ | ...
+
+--
+-- Cleanup.
+--
+box.execute([[SET SESSION "sql_full_metadata" =3D false;]]);
+ | ---
+ | - row_count: 1
+ | ...
+box.execute("DROP TABLE test;");
+ | ---
+ | - row_count: 1
+ | ...
diff --git a/test/sql/gh-4755-scalar-collation-metadata.test.lua =
b/test/sql/gh-4755-scalar-collation-metadata.test.lua
new file mode 100755
index 000000000..20158662e
--- /dev/null
+++ b/test/sql/gh-4755-scalar-collation-metadata.test.lua
@@ -0,0 +1,18 @@
+env =3D require('test_run')
+test_run =3D env.new()
+
+--
+-- gh-4755: collation in metadata must be displayed for both
+-- string and scalar field types.
+--
+test_run:cmd("setopt delimiter ';'");
+box.execute([[SET SESSION "sql_full_metadata" =3D true;]]);
+box.execute([[CREATE TABLE test (a SCALAR COLLATE "unicode_ci" PRIMARY =
KEY,
+                                 b STRING COLLATE "unicode_ci");]]);
+box.execute("SELECT * FROM test;");
+
+--
+-- Cleanup.
+--
+box.execute([[SET SESSION "sql_full_metadata" =3D false;]]);
+box.execute("DROP TABLE test;");