From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 7FB5426A26
	for <tarantool-patches@freelists.org>; Fri, 29 Jun 2018 10:00:05 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id rYngnFTM4_hL for <tarantool-patches@freelists.org>;
	Fri, 29 Jun 2018 10:00:05 -0400 (EDT)
Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2418726A12
	for <tarantool-patches@freelists.org>; Fri, 29 Jun 2018 10:00:05 -0400 (EDT)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: [tarantool-patches] Re: [PATCH v2 1/3] sql: introduce pragma sql_default_engine
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <6271c2d9b369110fac3586e662b8838bec242d72.1530202680.git.kshcherbatov@tarantool.org>
Date: Fri, 29 Jun 2018 17:00:02 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <3AA22731-F304-4173-BE6D-B5AAF7AF6BC9@tarantool.org>
References: <cover.1530202680.git.kshcherbatov@tarantool.org>
 <cover.1530202680.git.kshcherbatov@tarantool.org>
 <6271c2d9b369110fac3586e662b8838bec242d72.1530202680.git.kshcherbatov@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>

These inputs leads to segfault:

box.cfg{}
\set language sql
pragma  sql_default_engine

Segmentation fault
  code: SEGV_MAPERR
  addr: 0x0
  context: 0x10701ee08
  siginfo: 0x10701eda0
Current time: 1530280267
Please file a bug at http://github.com/tarantool/tarantool/issues
Attempting backtrace... Note: since the server has already crashed,=20
this may fail as well
#0  0x1046152cd in print_backtrace+d
#1  0x1044cdbb3 in _ZL12sig_fatal_cbiP9__siginfoPv+1f3
#2  0x7fffea9eab3a in _sigtramp+1a
#3  0x7fffea86c43c in strcasecmp_l+5a
#4  0x104630509 in strindex+69
#5  0x10487b214 in sql_default_engine_set+24
#6  0x10487a979 in sqlite3Pragma+1b69
#7  0x1048333f2 in yy_reduce+3072
#8  0x10482fdfa in sqlite3Parser+11a
#9  0x10489701d in sqlite3RunParser+43d
#10 0x10487cc10 in sqlite3Prepare+170
#11 0x10487c643 in sqlite3LockAndPrepare+83
#12 0x10487c73f in sqlite3_prepare_v2+4f
#13 0x1045e8fe2 in lua_sql_execute+92
#14 0x104642eed in lj_BC_FUNCC+44
#15 0x104671540 in lua_pcall+210
#16 0x1045f9bd3 in luaT_call+23
#17 0x1045f0b11 in lua_main+d1
#18 0x1045f08f8 in run_script_f+8e8
#19 0x1044cd4aa in _ZL16fiber_cxx_invokePFiP13__va_list_tagES0_+1a
#20 0x104610dbb in fiber_loop+bb
#21 0x10482f827 in coro_init+57

Also, it reproduces with:

pragma sql_default_engine 1

pragma sql_default_engine =E2=80=98memtx=E2=80=99=20

Some pragmas support such syntax, so lets handle this situation
in a polite way.

Moreover, simple =E2=80=98pragma=E2=80=99 command displays list of =
available pragmas and
their statuses. Lets add =E2=80=99sql_default_engine=E2=80=99 to that =
list.