From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 41DD9CE2D47; Thu, 22 Aug 2024 16:49:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 41DD9CE2D47 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724334578; bh=Q+tJ9qF57oqjZh8C72A0K0LRsVwf7+NFjMXL+/aPutE=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=TZDZclb3JX/j5foydQMeQdTXjWgufoFDaiG5o10ICj++92oU9XeEjHDNU9CO5cddS y+7oCaIwbCsb5CgP+R1V/WJ9FVtAcB8ZDjErMQl3FwxGvuh6Ql33aMI4/SKV6nThuJ 8g/fNGmV4loCGP/Ce4vlpDH2c30sVQSwv6LayUvM= Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [95.163.41.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 20E3CCE2D41 for ; Thu, 22 Aug 2024 16:49:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 20E3CCE2D41 Received: by smtp46.i.mail.ru with esmtpa (envelope-from ) id 1sh8Bs-0000000ADp7-2GDC; Thu, 22 Aug 2024 16:49:28 +0300 Content-Type: multipart/alternative; boundary="------------i7G8yhcRRqoJyn2khawzYarb" Message-ID: <39c58c9e-a038-4d32-a55c-fce96f6314da@tarantool.org> Date: Thu, 22 Aug 2024 16:49:28 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9A67092BE052B1D9E31015FC5902C0B2438B46547866FC5B0182A05F53808504084309D9552F21E82C591814E25D11F9F02781707A697250282BBE18FB0487B48AF7879D52E6103F3 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7235646FAB97B4BEDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637329F9579A0E72DCC8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D84BBC5883B64B9FCD31CAB52C52B2671A66732345F356C832CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F790063741F7343E26298569389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F790063741880789376DFC6ED81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE7541FADD3D81556A7EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3045DD857D6FE754135872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5F367FF8C3E9B14845002B1117B3ED696960CD2E3BC4F400630C8F815570A3530823CB91A9FED034534781492E4B8EEADEF0AF71940E62277BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF17254B74CD9B540DF009FCD98EF8633EA8B40096BEF5C09CC86666D5B92E8EEEFB7A4CF61EC7A84F2FB0CAD32ADFBF84E342CAABFE94693CB2EC136D788E6A37764D974C89710FC85F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbUwDRTee1Xr1KM20Xlj3JQ== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D6140E6773CA91244494892588099F419A1C5D7B41922698A562E0152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 33/45] test: refactor LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------i7G8yhcRRqoJyn2khawzYarb Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sergey, On 21.08.2024 11:58, Sergey Kaplun wrote: > This patch refactors the aforementioned test to make its code style > closer to ours. > > Relates to tarantool/tarantool#9398 > --- thanks for the patch! LGTM > test/LuaJIT-tests/trace/stack_purge.lua | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/test/LuaJIT-tests/trace/stack_purge.lua b/test/LuaJIT-tests/trace/stack_purge.lua > index 6d2876af..e4108b20 100644 > --- a/test/LuaJIT-tests/trace/stack_purge.lua > +++ b/test/LuaJIT-tests/trace/stack_purge.lua > @@ -11,11 +11,11 @@ local function b() > end > > local function c() > - for j=1,10 do > - for i=1,50 do b() b() b() end > + for _ = 1, 10 do > + for _ = 1, 50 do b() b() b() end > collectgarbage() > local t = {} > - for i=1,50 do t = {t} end > + for _ = 1, 50 do t = {t} end > end > end > --------------i7G8yhcRRqoJyn2khawzYarb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Sergey,

On 21.08.2024 11:58, Sergey Kaplun wrote:
This patch refactors the aforementioned test to make its code style
closer to ours.

Relates to tarantool/tarantool#9398
---
thanks for the patch! LGTM
 test/LuaJIT-tests/trace/stack_purge.lua | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/test/LuaJIT-tests/trace/stack_purge.lua b/test/LuaJIT-tests/trace/stack_purge.lua
index 6d2876af..e4108b20 100644
--- a/test/LuaJIT-tests/trace/stack_purge.lua
+++ b/test/LuaJIT-tests/trace/stack_purge.lua
@@ -11,11 +11,11 @@ local function b()
 end
 
 local function c()
-  for j=1,10 do
-    for i=1,50 do b() b() b() end
+  for _ = 1, 10 do
+    for _ = 1, 50 do b() b() b() end
     collectgarbage()
     local t = {}
-    for i=1,50 do t = {t} end
+    for _ = 1, 50 do t = {t} end
   end
 end
--------------i7G8yhcRRqoJyn2khawzYarb--