From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [tarantool-patches] Re: [PATCH v2 10/11] evio: make code C compatible References: <5de32046edfdd972b3227e673b4bd274f95fff95.1543958698.git.v.shpilevoy@tarantool.org> <20181205085641.xeqwhhk6zzy4h3sj@esperanza> From: Vladislav Shpilevoy Message-ID: <39bfd55e-3e68-6f2d-8255-8cca147511a9@tarantool.org> Date: Wed, 5 Dec 2018 23:07:03 +0300 MIME-Version: 1.0 In-Reply-To: <20181205085641.xeqwhhk6zzy4h3sj@esperanza> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit To: tarantool-patches@freelists.org, Vladimir Davydov List-ID: On 05/12/2018 11:56, Vladimir Davydov wrote: > On Wed, Dec 05, 2018 at 12:28:47AM +0300, Vladislav Shpilevoy wrote: >> --- >> src/evio.cc | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/src/evio.cc b/src/evio.cc >> index a3d1d8a13..8f5022bca 100644 >> --- a/src/evio.cc >> +++ b/src/evio.cc >> @@ -167,9 +167,10 @@ evio_service_name(struct evio_service *service) >> * callback. >> */ >> static void >> -evio_service_accept_cb(ev_loop * /* loop */, ev_io *watcher, >> - int /* revents */) >> +evio_service_accept_cb(ev_loop *loop, ev_io *watcher, int events) >> { >> + (void) loop; >> + (void) events; >> struct evio_service *service = (struct evio_service *) watcher->data; >> int fd; >> while (1) { > > This doesn't deserve a separate patch. Squash it into patch 11 please. > No need to resend the patch. > Done on the branch.