From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id CEA1420F2B for ; Mon, 7 May 2018 09:08:40 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TRQbp_Q6zfhx for ; Mon, 7 May 2018 09:08:40 -0400 (EDT) Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3067020F1D for ; Mon, 7 May 2018 09:08:39 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 1/1] Tests for CREATE TEMP TABLE and CREATE TEMPORARY TABLE References: From: Vladislav Shpilevoy Message-ID: <399639c2-dcd6-da4b-8402-f0ec10f3ea74@tarantool.org> Date: Mon, 7 May 2018 16:08:37 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Roman Khabibov Hello. My congratulations on your first contribution! The patch is almost perfect with 2 minor comments: 1. Please, in the commit title write a Tarantool submodule prefix. For example, your patch is about SQL, so you would write 'sql: ' prefix. On 06/05/2018 01:34, Roman Khabibov wrote: > Added tests for removed SQL functions "CREATE TEMP TABLE" and "CREATE > TEMPORARY". There is exeptions, when these functions are used. Tests catch its. > > Closes #2166 > --- > test/sql-tap/table.test.lua | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/test/sql-tap/table.test.lua b/test/sql-tap/table.test.lua > index 6e10561..4882b18 100755 > --- a/test/sql-tap/table.test.lua > +++ b/test/sql-tap/table.test.lua > @@ -1,6 +1,6 @@ > #!/usr/bin/env tarantool > test = require("sqltester") > -test:plan(56) > +test:plan(58) > > --!./tcltestrunner.lua > -- 2001 September 15 > @@ -611,6 +611,24 @@ test:do_execsql2_test( > -- SELECT * FROM [t4"abc]; > -- } > -- } {cnt 1 max(b+c) 5} 2. Before the test cases write in comments what do you test here, and write a link to the issue in the format 'gh-NNNN: description'. Example: https://github.com/tarantool/tarantool/blob/2.0/test/sql/iproto.test.lua#L122 > +test:do_catchsql_test( > + "temp", > + [[ > + CREATE TEMP TABLE > + ]], { > + -- > + 1, "near \"TEMP\": syntax error" > + -- > + }) > +test:do_catchsql_test( > + "temporary", > + [[ > + CREATE TEMPORARY TABLE > + ]], { > + -- > + 1, "near \"TEMPORARY\": syntax error" > + -- > + }) > test:do_execsql2_test( > "table-8.6", > [[ >