From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 99EB7469710 for ; Tue, 9 Jun 2020 15:20:43 +0300 (MSK) From: Serge Petrenko Date: Tue, 9 Jun 2020 15:20:13 +0300 Message-Id: <3992b9bc805ebc1d83ff59d5c1050b89a6a66344.1591701695.git.sergepetrenko@tarantool.org> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH 1/8] replication: introduce space.is_sync option List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: v.shpilevoy@tarantool.org, sergos@tarantool.org, gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org From: Vladislav Shpilevoy Synchronous space makes every transaction, affecting its data, wait until it is replicated on a quorum of replicas before it is committed. Part of #4844 --- src/box/lua/schema.lua | 2 + src/box/lua/space.cc | 5 +++ src/box/space_def.c | 2 + src/box/space_def.h | 6 +++ .../sync_replication_sanity.result | 39 +++++++++++++++++++ .../sync_replication_sanity.test.lua | 16 ++++++++ 6 files changed, 70 insertions(+) create mode 100644 test/replication/sync_replication_sanity.result create mode 100644 test/replication/sync_replication_sanity.test.lua diff --git a/src/box/lua/schema.lua b/src/box/lua/schema.lua index e6844b45f..a91b4fbad 100644 --- a/src/box/lua/schema.lua +++ b/src/box/lua/schema.lua @@ -413,6 +413,7 @@ box.schema.space.create = function(name, options) format = 'table', is_local = 'boolean', temporary = 'boolean', + is_sync = 'boolean', } local options_defaults = { engine = 'memtx', @@ -457,6 +458,7 @@ box.schema.space.create = function(name, options) local space_options = setmap({ group_id = options.is_local and 1 or nil, temporary = options.temporary and true or nil, + is_sync = options.is_sync }) _space:insert{id, uid, name, options.engine, options.field_count, space_options, format} diff --git a/src/box/lua/space.cc b/src/box/lua/space.cc index d0e44dd41..177c58830 100644 --- a/src/box/lua/space.cc +++ b/src/box/lua/space.cc @@ -253,6 +253,11 @@ lbox_fillspace(struct lua_State *L, struct space *space, int i) lua_pushstring(L, space->def->engine_name); lua_settable(L, i); + /* space.is_sync */ + lua_pushstring(L, "is_sync"); + lua_pushboolean(L, space->def->opts.is_sync); + lua_settable(L, i); + lua_pushstring(L, "enabled"); lua_pushboolean(L, space_index(space, 0) != 0); lua_settable(L, i); diff --git a/src/box/space_def.c b/src/box/space_def.c index efb1c8ee9..83566bf02 100644 --- a/src/box/space_def.c +++ b/src/box/space_def.c @@ -41,6 +41,7 @@ const struct space_opts space_opts_default = { /* .is_temporary = */ false, /* .is_ephemeral = */ false, /* .view = */ false, + /* .is_sync = */ false, /* .sql = */ NULL, }; @@ -48,6 +49,7 @@ const struct opt_def space_opts_reg[] = { OPT_DEF("group_id", OPT_UINT32, struct space_opts, group_id), OPT_DEF("temporary", OPT_BOOL, struct space_opts, is_temporary), OPT_DEF("view", OPT_BOOL, struct space_opts, is_view), + OPT_DEF("is_sync", OPT_BOOL, struct space_opts, is_sync), OPT_DEF("sql", OPT_STRPTR, struct space_opts, sql), OPT_DEF_LEGACY("checks"), OPT_END, diff --git a/src/box/space_def.h b/src/box/space_def.h index 788b601e6..198242d02 100644 --- a/src/box/space_def.h +++ b/src/box/space_def.h @@ -67,6 +67,12 @@ struct space_opts { * this flag can't be changed after space creation. */ bool is_view; + /** + * Synchronous space makes all transactions, affecting its + * data, synchronous. That means they are not applied + * until replicated to a quorum of replicas. + */ + bool is_sync; /** SQL statement that produced this space. */ char *sql; }; diff --git a/test/replication/sync_replication_sanity.result b/test/replication/sync_replication_sanity.result new file mode 100644 index 000000000..813c7b27b --- /dev/null +++ b/test/replication/sync_replication_sanity.result @@ -0,0 +1,39 @@ +-- test-run result file version 2 +-- +-- gh-4282: synchronous replication. It allows to make certain +-- spaces commit only when their changes are replicated to a +-- quorum of replicas. +-- +s = box.schema.create_space('test', {is_sync = true}) + | --- + | ... +s.is_sync + | --- + | - true + | ... +pk = s:create_index('pk') + | --- + | ... +box.begin() s:insert({1}) s:insert({2}) box.commit() + | --- + | ... +s:select{} + | --- + | - - [1] + | - [2] + | ... +s:drop() + | --- + | ... + +-- Default is async. +s = box.schema.create_space('test') + | --- + | ... +s.is_sync + | --- + | - false + | ... +s:drop() + | --- + | ... diff --git a/test/replication/sync_replication_sanity.test.lua b/test/replication/sync_replication_sanity.test.lua new file mode 100644 index 000000000..34dcaee61 --- /dev/null +++ b/test/replication/sync_replication_sanity.test.lua @@ -0,0 +1,16 @@ +-- +-- gh-4282: synchronous replication. It allows to make certain +-- spaces commit only when their changes are replicated to a +-- quorum of replicas. +-- +s = box.schema.create_space('test', {is_sync = true}) +s.is_sync +pk = s:create_index('pk') +box.begin() s:insert({1}) s:insert({2}) box.commit() +s:select{} +s:drop() + +-- Default is async. +s = box.schema.create_space('test') +s.is_sync +s:drop() -- 2.24.3 (Apple Git-128)