From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6954E21E4A for ; Mon, 2 Jul 2018 04:46:06 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id he1QPmSGdc0g for ; Mon, 2 Jul 2018 04:46:06 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 299E321A8A for ; Mon, 2 Jul 2018 04:46:06 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v2 3/3] sql: enable multi-engine tests for SQL References: <84788764-363B-483A-8353-5A3FD61B1F7F@tarantool.org> From: Kirill Shcherbatov Message-ID: <3961d92b-b56e-8612-e97c-c09ed87ea977@tarantool.org> Date: Mon, 2 Jul 2018 11:46:03 +0300 MIME-Version: 1.0 In-Reply-To: <84788764-363B-483A-8353-5A3FD61B1F7F@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Nikita Pettik > Could we disable them for vinyl somehow and run only once? > Some of them take long time to execute. This way: +++ b/test/sql-tap/engine.cfg @@ -1,4 +1,7 @@ { + "analyze9.test.lua": { + "memtx": {"engine": "memtx"} + }, "*": { "memtx": {"engine": "memtx"}, "vinyl": {"engine": "vinyl"} +++ b/test/sql-tap/analyze9.test.lua - pragma sql_default_engine='memtx'; > Lets put newline at the end of file. Ok, fixed on merge. > Please, use types for columns: we are going to introduce static types > in SQL and make them mandatory. -box.sql.execute("CREATE TABLE t1_vinyl(a primary key,b,c);") -box.sql.execute("CREATE TABLE t2_vinyl(a primary key,b,c);") +box.sql.execute("CREATE TABLE t1_vinyl(a INT PRIMARY KEY, b INT, c INT);") +box.sql.execute("CREATE TABLE t2_vinyl(a INT PRIMARY KEY, b INT, c INT);") -box.sql.execute("CREATE TABLE t3_memtx(a primary key,b,c);") +box.sql.execute("CREATE TABLE t3_memtx(a INT PRIMARY KEY, b INT, c INT);")