From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 309314AC1B8; Wed, 14 Jun 2023 11:42:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 309314AC1B8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1686732173; bh=IZnr2eIspB9w7t+HOLFreCkOLasp+wJuHyeQmNl0IZU=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=it5bTt9otYqfQbJem3f8ZyBioZLUfPQRibmCL1HlL5QPqrOd/odtlNR/9fs9tdh6K dE/nG+UCywpOX0RxOW745f+71ZbuIhnhBHBBuaY6QjBSm6qOcKZNQBIySOqII87H5N Bi+xmreMqtXYjNnD6ynADC5jDJY4D68I/f9G0ZQA= Received: from smtp30.i.mail.ru (smtp30.i.mail.ru [95.163.41.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CEC824A0A1F for ; Wed, 14 Jun 2023 11:42:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CEC824A0A1F Received: by smtp30.i.mail.ru with esmtpa (envelope-from ) id 1q9M5a-0077tP-LM; Wed, 14 Jun 2023 11:42:51 +0300 Message-ID: <393d80f6-aa44-e170-eec1-dd0337a4e613@tarantool.org> Date: Wed, 14 Jun 2023 11:42:49 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 To: Sergey Kaplun , Igor Munkin , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: <1d7992b7f849ed5fa1d6542bf584da3281145c11.1686383897.git.skaplun@tarantool.org> Content-Language: en-US In-Reply-To: <1d7992b7f849ed5fa1d6542bf584da3281145c11.1686383897.git.skaplun@tarantool.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD95D99986233CC4DDCFB14F17D0E9EAA49C0FEF2B22CA0AFAD182A05F538085040C5142BE58D4A6D64AAB18A163BB13215B2C97F758FD8E1EE079C12A912BF22FD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE704FFE27C31EF363AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637775FFFCA96730EC9EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BE5CCB53A13BC8DBA443ECD91E75389019621A0800A50C378CC7F00164DA146DAFE8445B8C89999728AA50765F79006377C70927E34808485389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8223C850C94764309F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CA0BCD6C998BE27722D242C3BD2E3F4C64AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C3940A41BBCF1845AABA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7B2B7C64F398C7410731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5527BE5E7D5622BE7EB2CBB000CA64C1FB6CB7A08F3A72BEBF87CCE6106E1FC07E67D4AC08A07B9B06A1CB4668A9CA5FACB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34D4E96E2A5B1100E07837A0C8FD5B43477707B3B4468ED5C121A2BFFC6305B9441855E6DAF967B1B41D7E09C32AA3244C27E25EDAC5F3ECDC8239D935BA578425853296C06374E602BAD658CF5C8AB4025DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojdUHSxnroE50Urc/EKfWu7w== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A7694CBDEC1790CBDABDAAB18A163BB13215009DB4CE3002C7DBEBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v4 luajit 1/6] test: fix setting of {DY}LD_LIBRARY_PATH variables X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch, Sergey. LGTM now. On 6/10/23 11:03, Sergey Kaplun wrote: > When we set `LUA_TEST_ENV_MORE` variable to be used in the additional > env command for run testing if `"` is used to wrap the `LD_LIBRARY_PATH` > value the content of this environment variable is literally > `"/abs/path1:/abs/path2:...:"`. So, the first entry is treated as the > relative path starting with `"`. In that case if we need the library to > be loaded via FFI for this particular test, that loading fails with the > error "cannot open shared object file", since the path to it is > incorrect. > > This patch removes `"` wrapping for the aforementioned variables. > > Without this patch, the rest patchset will lead to persistent failing of > the as far as its > subdirectory (with helper C library for it) mentioned as the last one. > --- > test/tarantool-tests/CMakeLists.txt | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt > index a428d009..38d6ae49 100644 > --- a/test/tarantool-tests/CMakeLists.txt > +++ b/test/tarantool-tests/CMakeLists.txt > @@ -102,6 +102,11 @@ endif() > # loaded modules on MacOS instead of shared libraries as it is > # done on Linux and BSD, another environment variable should be > # used to guide while searching the extension. > +# XXX: Be noticed that we shouldn't use `"` here to wrap > +# the variable's content. If we do this, the variable value will > +# contain `"` at the beginning and the end, so this `"` at the > +# beginning will be treated as the directory for the first entry > +# (the last subdirectory added). > if(CMAKE_SYSTEM_NAME STREQUAL "Darwin") > # XXX: Apple tries their best to "protect their users from > # malware". As a result SIP (see the link[1] below) has been > @@ -122,9 +127,9 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Darwin") > # > # [1]: https://support.apple.com/en-us/HT204899 > # [2]: https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/RuntimeProtections/RuntimeProtections.html > - list(APPEND LUA_TEST_ENV_MORE DYLD_LIBRARY_PATH="${LD_LIBRARY_PATH}") > + list(APPEND LUA_TEST_ENV_MORE DYLD_LIBRARY_PATH=${LD_LIBRARY_PATH}) > else() > - list(APPEND LUA_TEST_ENV_MORE LD_LIBRARY_PATH="${LD_LIBRARY_PATH}") > + list(APPEND LUA_TEST_ENV_MORE LD_LIBRARY_PATH=${LD_LIBRARY_PATH}) > endif() > > # LUA_CPATH and LD_LIBRARY_PATH variables and also TESTLIBS list