From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 599656EC5B; Wed, 12 May 2021 21:41:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 599656EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1620844905; bh=o44djEdq0tarXcNo8TNv2gMoWBsAWwg33QWXSfCwOQk=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=WPqt/rWvIS8rLsvnnKSLgaHA+3B8SSpq1a3KCLJkGyFT7PGis9RiuCml+5bpBxK90 S6lHxxG6HxqnftS+Eww4BhRVXfQePps7JThgJdtf+ODlYidJCMwrz/AUek3CX1nqJI r9FckkH2stTMLlGfSxKAOM56QM+E86xfT/ByeFxw= Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3EA9C6EC5B for ; Wed, 12 May 2021 21:41:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3EA9C6EC5B Received: by smtp43.i.mail.ru with esmtpa (envelope-from ) id 1lgtnj-0007RW-4J; Wed, 12 May 2021 21:41:43 +0300 To: Cyrill Gorcunov References: <20210504155819.290874-1-gorcunov@gmail.com> Message-ID: <3917eb85-85e6-56d1-4176-7d6926587a49@tarantool.org> Date: Wed, 12 May 2021 20:41:42 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD95978C26455E69BE0BB6090B4F8997C21AA3492AFA30115D5182A05F5380850402253B2FFE2B71C3AEB6B4D9A655812880C57C98A38567B71282F669C9EEB0109 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70312E9A300D47E3BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375F0BD5CF353A411D8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B26DE3A8CC58C571D5BD87E00FAF16901D40B83DF1158C6122D2E47CDBA5A96583C09775C1D3CA48CFCF36E64A7E3F8E58117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE7985FEE833124D2D39FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE76901C0A24B2B0010D32BA5DBAC0009BE395957E7521B51C20BC6067A898B09E4090A508E0FED6299176DF2183F8FC7C0CF6F77B9BC2E078CCD04E86FAF290E2D7E9C4E3C761E06A71DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6300D3B61E77C8D3B089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A23F051236DBC9DA6306C627C4D753511DAE0174B7F1092AFB33D95F36BF6667CA2D7FDBE3D9A88E41 X-C1DE0DAB: 0D63561A33F958A5EE0E35CB9D96F87853BAC1B3935475500EC1EDE140B3C9EED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D347341ACA13FB8BDD9629A7255F07B520D082ED3AB2041901694A45212CC0E311D2B0E37D267856BEC1D7E09C32AA3244CBD8592B27465ED35B90899B572735FE2B4DF56057A86259F927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojo6y/qPNd2uxzC69BbRNXvQ== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA3110332B46C6AE140DC4CED944955390C86614ABFD4A8FBEAC7907784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3 00/10] fix say_x format and rework fibers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Cc: tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 11.05.2021 23:24, Cyrill Gorcunov wrote: > On Wed, May 12, 2021 at 12:15:39AM +0300, Cyrill Gorcunov wrote: >> On Tue, May 11, 2021 at 10:13:01PM +0200, Vladislav Shpilevoy wrote: >>> Hi! Good job on the fixes, really! >>> >>> Although function lbox_fiber_statof() still uses lua_pushinteger(): >>> >> >> Thanks a huge for catching it, Vlad. Here is an update. Squashed >> to patch 1 "fiber: use uint64_t for fiber IDs" and force pushed. > > And one more addon (squashed) because 20 chars won't fit 8 byte > unsiged together with "fiber: " prefix. Also I'm a bit worried of > > static int > lbox_fiber_top_entry(struct fiber *f, void *cb_ctx) > { > struct lua_State *L = (struct lua_State *) cb_ctx; > > --> lua_pushfstring(L, "%f/%s", (lua_Number)f->fid, f->name); > > why do we use float formate here at all?! Because lua_pushfstring() does not support %llu.