From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6F4B326138 for ; Thu, 14 Jun 2018 18:46:59 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fuetK2vphZPg for ; Thu, 14 Jun 2018 18:46:59 -0400 (EDT) Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2F1E026163 for ; Thu, 14 Jun 2018 18:46:59 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [tarantool-patches] Re: [PATCH v3 02/10] sql: fix leak on CREATE TABLE and resolve self ref From: "n.pettik" In-Reply-To: Date: Fri, 15 Jun 2018 01:46:57 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <3833E5C5-1D99-442A-B0FC-101EC24E9FD7@tarantool.org> References: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Kirill Shcherbatov Nitpicking: if you can=E2=80=99t fit commit subject into 50 chars, you are able to shrink it and instead write about it in commit message. Like: sql: fix memory leaks This patch fixes several memory leaks. One of them appeared during introducing space_def in struct Table. Name of table wasn=E2=80=99t = released in case of successful returning from function sqlite3StartTable(). Second one - bla-bla-bla. It is only advise, tho. But I stick to the point that describing = provided changes aren=E2=80=99t less important then code itself. Patch itself looks OK to me.=