From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3D26723AA0 for ; Fri, 4 May 2018 14:05:27 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8TyIMpJXp5Rv for ; Fri, 4 May 2018 14:05:27 -0400 (EDT) Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 88BAB2382B for ; Fri, 4 May 2018 14:05:26 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 00/12] vinyl: prepare read iterator for index rebuild References: From: Vladislav Shpilevoy Message-ID: <3810a3cb-8051-3baa-10af-97ce036e38fe@tarantool.org> Date: Fri, 4 May 2018 21:05:23 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, kostja@tarantool.org Hello. The whole patchset LGTM except one memory leak. Kostja already pushed it, so I fixed it on the branch: vy-fix-memleak. On 15/04/2018 22:55, Vladimir Davydov wrote: > To be able to use read iterator for building secondary indexes in vinyl, > we need it to guarantee that the returned tuple is always the newest > version, which is currently not true. Fix that. > > https://github.com/tarantool/tarantool/commits/vy-prep-read-iterator-for-alter > > Vladimir Davydov (12): > vinyl: rename vy_stmt_history to vy_history > vinyl: factor out vy_history_apply from vy_point_lookup_apply_history > vinyl: add vy_history_append_stmt helper > vinyl: zap iterator_src_type enum > vinyl: encapsulate key history with struct > vinyl: refine vy_history_cleanup > vinyl: move vy_history to its own source file > vinyl: use mempool for vy_history_node allocations > vinyl: consolidate skip optimization checks in read iterator > vinyl: refactor vy_read_iterator_next > vinyl: make read iterator always return newest tuple version > vinyl: zap vy_read_iterator::curr_stmt > > src/box/CMakeLists.txt | 1 + > src/box/vy_cache.c | 51 ++--- > src/box/vy_cache.h | 31 +-- > src/box/vy_history.c | 115 ++++++++++ > src/box/vy_history.h | 165 +++++++++++++ > src/box/vy_lsm.c | 5 + > src/box/vy_lsm.h | 4 +- > src/box/vy_mem.c | 93 +++----- > src/box/vy_mem.h | 33 +-- > src/box/vy_point_lookup.c | 228 +++--------------- > src/box/vy_read_iterator.c | 560 +++++++++++++++++++-------------------------- > src/box/vy_read_iterator.h | 11 +- > src/box/vy_run.c | 68 ++++-- > src/box/vy_run.h | 23 +- > src/box/vy_tx.c | 55 +++-- > src/box/vy_tx.h | 29 ++- > test/unit/CMakeLists.txt | 3 + > test/unit/vy_cache.c | 16 +- > test/unit/vy_mem.c | 24 +- > test/vinyl/upsert.result | 8 +- > test/vinyl/upsert.test.lua | 6 +- > 21 files changed, 788 insertions(+), 741 deletions(-) > create mode 100644 src/box/vy_history.c > create mode 100644 src/box/vy_history.h >