From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4E5182E131 for ; Sun, 26 May 2019 08:03:28 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IcTJBic83cpd for ; Sun, 26 May 2019 08:03:28 -0400 (EDT) Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 93ED82E113 for ; Sun, 26 May 2019 08:03:27 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v4 1/4] schema: add new system space for CHECK constraints References: <6780ecce-2186-9f6c-6b4e-133ad98ddafa@tarantool.org> From: Vladislav Shpilevoy Message-ID: <37f6781a-1317-bca3-5c08-c2b67fc45073@tarantool.org> Date: Sun, 26 May 2019 15:03:24 +0300 MIME-Version: 1.0 In-Reply-To: <6780ecce-2186-9f6c-6b4e-133ad98ddafa@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Kirill Shcherbatov , tarantool-patches@freelists.org >>> + * To perform it transactionally, we create a list of a new ck >> >> 5. 'a' article is never used with plural. > It is not plural here. A list ... Somewhy you trimmed the context, but here it is again: "we create a list of a new ck constraints objects" You wrote "a new ck constraints objects". Firstly, "a objects" is incorrect. Secondly, if you want to describe an object as purposed to something, you do not need plural. It should be "we create a list of new ck constraint objects" "constraints" -> "constraint", it is like an adjective here. "a objects" -> "objects". You can't use 'a' with plural. >>> + /* >>> + * FIXME: Ck constraint creation on non-empty >>> + * space must be implemented as preparatory >>> + * step for ALTER SPACE ADD CONSTRAINT feature. >> >> 8. We already have ADD CONSTRAINT. It works for FK, UNIQUE, PK. The >> problem is that we can't call it on a non-empty space. > https://github.com/tarantool/tarantool/issues/4243 My comment was rather about incorrect comment - "ADD CONSTRAINT" is already implemented, but here you state, that it is not so. The comment is still incorrect.