From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0F2C8469710 for ; Thu, 4 Jun 2020 00:47:57 +0300 (MSK) References: From: Vladislav Shpilevoy Message-ID: <37b51022-92fe-605f-2335-a1e6c77d9584@tarantool.org> Date: Wed, 3 Jun 2020 23:47:56 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH] lua: show error on attempt to access to tuple of unsupported type List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org Cc: alexander.turenko@tarantool.org Hi! I dove into the issue context, and from what I see, this commit does not fix anything. The issue is much deeper that just msgpackffi decoder problem. Moreover, you said it is 'fixed' for 1.10, but the problem exists not only on 1.10. It is a general problem of any version interacting with any newer version. Besides, I see Alexander Tu. provided lots of comments, which you didn't address. So please, proceed with fixing his comments first. In my opinion, we should hide spaces with unknown fields. I.e. whose tuple_format object couldn't be created on the client side. It looks like the simplest option. The client anyway can't do anything useful with these spaces.