From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 654E16EC55; Sat, 31 Jul 2021 09:31:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 654E16EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627713070; bh=3+8VnTs/rGsXMEqMSvW7KsoTyJjFNpggMEQj7MbaXO4=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=SJa+Z+LrUdNi1UaHMvorvzUHB59X78uhVdc0qc0FJgE+Q3vraKihKSN9Bs4212P0/ 24ua7dpJfYhVMqr3xFms/g/79y9CeY/dSA27YiNFX3DZXSpafArareh2IQsQnmPcW/ rvThFgFKJL2OcXlywbyuTnnbgnc0wi7PbhLMewA0= Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8E7DB6EC55 for ; Sat, 31 Jul 2021 09:31:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8E7DB6EC55 Received: by smtp3.mail.ru with esmtpa (envelope-from ) id 1m9iWW-00051B-99; Sat, 31 Jul 2021 09:31:05 +0300 To: Timur Safin , v.shpilevoy@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <1c56006b-159a-f68e-bde0-b718b92974ce@tarantool.org> <045501d78592$8167c560$84375020$@tarantool.org> Message-ID: <378606f5-02d7-68a2-4efe-8fc68e7fef83@tarantool.org> Date: Sat, 31 Jul 2021 09:31:03 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <045501d78592$8167c560$84375020$@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C36A98DBA789EBB6AE26DB9A6C1D9BF7E0182A05F538085040EE934EF26C8BAB873F97DEE312883650B7D5ADF213FF6EF33BB0ADCFDDFE844B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7370F4F695FFFC24BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637829D9538242026C38638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D843222191F2F43F1F32A88C7CF270BFCD117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18CB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE4B6963042765DA4BA5FD2DD08EB4836CD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3A7DFDF579AB090EF040F9FF01DFDA4A8C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637A8A59EE88DA1D479EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A52FE315762BB04CFEA7CDF85E425E5F80E940CE44B9BE76C5D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA751B940EDA0DFB0535410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343D1F112031EF3D62F4582DAE7585685F1396CA4C0DAB7C472C552B3E627CDCE5D3083B212B2451DE1D7E09C32AA3244C74354810C9E90CD6955D61C07A1A4E295595C85A795C7BAEFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojNLQ8Cqcv1iuYHn7v5Xdl0w== X-Mailru-Sender: 583F1D7ACE8F49BD1042885CEC987B6BEA7BA8D326E746783F97DEE3128836506CCF71F689FD47EE7019711D9D5B048E1458020726E2BC9FD5ECBA0B92C0A936CDC7563AA7CEBD287402F9BA4338D657ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH resend v2 08/11] lua, datetime: calculated attributes for datetimes X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Oleg Babin via Tarantool-patches Reply-To: Oleg Babin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for your reply. See my comment below. On 31.07.2021 01:30, Timur Safin wrote: > Hello Oleg again! > > : > : > : On 28.07.2021 13:34, Timur Safin via Tarantool-patches wrote: > : > * introduced a set of calculated attributes to data object, e.g.: > : > - timestamp, seconds, microseconds, minute, or hours > : > > : > Part of #5941 > : > --- > : > src/lua/datetime.lua | 51 ++++++++++++++++++++++------------ > : > test/app-tap/datetime.test.lua | 17 +++++++++++- > : > 2 files changed, 50 insertions(+), 18 deletions(-) > : > > : > diff --git a/src/lua/datetime.lua b/src/lua/datetime.lua > : > index 9ec06d8d8..7a208cef9 100644 > : > --- a/src/lua/datetime.lua > : > +++ b/src/lua/datetime.lua > : > @@ -224,6 +224,36 @@ local function interval_serialize(self) > : > return { secs = self.secs, nsec = self.nsec } > : > end > : > > : > +local datetime_index = function(self, key) > : > + local attributes = { > : > : This change looks like pessimization because currently we need to > : recreate "attributes" table > : > : for each function call. I suggest to use `attributes` as `__index` but > : not such function. > > What would you say if I simply precache this attributes table in local, > and then proceed this way? > ----------------------------------------- > -local datetime_index = function(self, key) > - local attributes = { > +local datetime_index_handlers = { > unixtime = function(self) > return self.secs > end, > + > timestamp = function(self) > return tonumber(self.secs) + self.nsec / 1e9 > end, > + > nanoseconds = function(self) > return self.secs * 1e9 + self.nsec > end, > + > microseconds = function(self) > return self.secs * 1e6 + self.nsec / 1e3 > end, > + > milliseconds = function(self) > return self.secs * 1e3 + self.nsec / 1e6 > end, > + > seconds = function(self) > return tonumber(self.secs) + self.nsec / 1e9 > end, > + > minutes = function(self) > return (tonumber(self.secs) + self.nsec / 1e9) / 60 > end, > + > hours = function(self) > return (tonumber(self.secs) + self.nsec / 1e9) / (60 * 60) > end, > + > days = function(self) > return (tonumber(self.secs) + self.nsec / 1e9) / (60 * 60) / 24 > end, > + > add = function(self) > return function(self, o) > return interval_increment(self, o, 1) > end > end, > + > sub = function(self) > return function(self, o) > return interval_increment(self, o, -1) > end > end, > } > - return attributes[key] ~= nil and attributes[key](self) or nil > + > +local datetime_index = function(self, key) > + return datetime_index_handlers[key] ~= nil and > + datetime_index_handlers[key](self) or nil > end > ----------------------------------------- > > I mean we still carefully check existence of an asked key, and return nil if > there is no such key at all. Is it much different than what you've meant? > It's again about temporary tables. I gave a benchmark in one of the previous emails. After changes it shoud be better. Thanks.