From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id AB012469710
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  2 Jun 2020 10:51:22 +0300 (MSK)
From: Oleg Babin <olegrok@tarantool.org>
References: <20200601222507.560415-1-gorcunov@gmail.com>
 <20200601222507.560415-6-gorcunov@gmail.com>
Message-ID: <37516925-8583-ef03-662a-a065ba2d69cd@tarantool.org>
Date: Tue, 2 Jun 2020 10:51:21 +0300
MIME-Version: 1.0
In-Reply-To: <20200601222507.560415-6-gorcunov@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v7 05/11] lua/log: do not allow to
 set json for boot logger
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>, tml <tarantool-patches@dev.tarantool.org>

Hi. Thanks for your patch see one comment.

On 02/06/2020 01:25, Cyrill Gorcunov wrote:
> pcall(log, {log_format = 'json'})

It seems to be incorrect.

```
tarantool> pcall(log, {log_format = 'json'})
---
- false
- attempt to call a table value
...
```

And it should be
```
tarantool> pcall(log.log_format, 'json')
---
- false
- 'builtin/log.lua:228: log_format: json can''t be used with syslog or 
boot-time logger'
...
```

Also please check error message. Smth like:
```
err:find('log_format: json can\'t be used with syslog or boot%-time 
logger') ~= nil
```