From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 78903469710 for ; Sun, 3 May 2020 21:47:44 +0300 (MSK) References: <20200428161137.20536-1-gorcunov@gmail.com> <20200428161137.20536-17-gorcunov@gmail.com> From: Vladislav Shpilevoy Message-ID: <37330c0f-bb83-e2c7-c185-347ff1d29a4b@tarantool.org> Date: Sun, 3 May 2020 20:47:43 +0200 MIME-Version: 1.0 In-Reply-To: <20200428161137.20536-17-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 16/17] box: use _xc helpers of recovery code List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cyrill Gorcunov , tml Thanks for the patch! Please, don't do that. You literally destroyed your own changes from the previous commits. Anyway box.cc and relay.cc will be eventually converted to C, and the task is getting more complex after this commit. On 28/04/2020 18:11, Cyrill Gorcunov wrote: > To shrink code a bit. You removed 8 lines from box.cc and 9 lines from relay.cc, but added 53 to recovery.h. And still both box.cc and relay.cc use != 0 and diag_raise() in other places.