From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 2D38E275F9
	for <tarantool-patches@freelists.org>; Thu, 22 Aug 2019 11:23:10 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id IEp5BEfiZvk7 for <tarantool-patches@freelists.org>;
	Thu, 22 Aug 2019 11:23:10 -0400 (EDT)
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E3A79275F8
	for <tarantool-patches@freelists.org>; Thu, 22 Aug 2019 11:23:09 -0400 (EDT)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: [tarantool-patches] Re: [PATCH v4 4/4] sql: support user-defined
 functions in SQL
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <9c29f1d8dfe7ab9b644a7e05bf5f47ccdd90e4a6.1566400979.git.kshcherbatov@tarantool.org>
Date: Thu, 22 Aug 2019 18:23:07 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <372F3EA5-1F1A-40D5-A285-C334B47EA9EA@tarantool.org>
References: <cover.1566400979.git.kshcherbatov@tarantool.org>
 <9c29f1d8dfe7ab9b644a7e05bf5f47ccdd90e4a6.1566400979.git.kshcherbatov@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>


> diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c
> index c5d91ceee..9fb217822 100644
> --- a/src/box/sql/vdbe.c
> +++ b/src/box/sql/vdbe.c
> @@ -46,6 +46,7 @@
> #include "box/fk_constraint.h"
> #include "box/txn.h"
> #include "box/tuple.h"
> +#include "box/port.h"
> #include "sqlInt.h"
> #include "vdbeInt.h"
> #include "tarantoolInt.h"
> @@ -1783,6 +1784,48 @@ case OP_BuiltinFunction: {
> 	break;
> }
>=20
> +/* Opcode: Function P1 P2 P3 P4 P5

Nit: P1 is unused. As a rule we spot unused arguments with stars (*).
And I=E2=80=99d swap P1 and P5, i.e. pass range of registers in P1-P2,
save result to P3

The rest now seems to be OK.=