From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tsafin@tarantool.org>
Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 09A95469710
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 19 May 2020 19:21:43 +0300 (MSK)
From: "Timur Safin" <tsafin@tarantool.org>
References: <194d73cbb844795fbe2a9a6599bb684f4e6a0cf2.1589584903.git.v.shpilevoy@tarantool.org>
In-Reply-To: <194d73cbb844795fbe2a9a6599bb684f4e6a0cf2.1589584903.git.v.shpilevoy@tarantool.org>
Date: Tue, 19 May 2020 19:21:38 +0300
Message-ID: <36fa01d62df9$94ec0250$bec406f0$@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Language: ru
Subject: Re: [Tarantool-patches] [PATCH v2 small 1/1] lsregion: introduce
	aligned alloc
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: 'Vladislav Shpilevoy' <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org, alyapunov@tarantool.org, gorcunov@gmail.com

Other than small note below it's looking great, but please keep in mind...

: From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
: Subject: [PATCH v2 small 1/1] lsregion: introduce aligned alloc
: 


: @@ -32,59 +32,62 @@
:  #include "lsregion.h"
: 
:  void *
: -lsregion_alloc_slow(struct lsregion *lsregion, size_t size, int64_t id)
: +lsregion_aligned_reserve_slow(struct lsregion *lsregion, size_t size,
: +			      size_t alignment, void **unaligned)
:  {
: -	struct lslab *slab = NULL;
: -	size_t slab_size = lsregion->arena->slab_size;
: +	void *pos;
: +	struct lslab *slab;
: +	struct slab_arena *arena = lsregion->arena;
: +	size_t slab_size = arena->slab_size;
: 
:  	/* If there is an existing slab then try to use it. */
:  	if (! rlist_empty(&lsregion->slabs.slabs)) {
:  		slab = rlist_last_entry(&lsregion->slabs.slabs, struct lslab,
:  					next_in_list);
:  		assert(slab != NULL);
: +		*unaligned = lslab_pos(slab);
: +		pos = (void *)small_align((size_t)*unaligned, alignment);
: +		if (pos + size <= lslab_end(slab))
: +			return pos;

Void* pointer arithmetic is non-standard, gcc extension, and I'd 
avoid to use it in a longer run. There are compilers is which still 
not support it. 

Timur