From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 261E3469710
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  8 May 2020 00:37:48 +0300 (MSK)
References: <e09e2aca2559cfa8c02d832ea357b9e2e9c7a3b0.1588286902.git.v.shpilevoy@tarantool.org>
 <20200506153843.GG112@tarantool.org>
 <9a29772d-0ade-5735-adc1-536d4e76a1f1@tarantool.org>
 <20200507102805.GI112@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <36d61026-e724-8f31-bd69-b89721b297d3@tarantool.org>
Date: Thu, 7 May 2020 23:37:46 +0200
MIME-Version: 1.0
In-Reply-To: <20200507102805.GI112@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 1/1] wal: simplify rollback
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Ostanevich <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

>>>>
>>>> Also there is now a single route for commit and rollback cbus
>>>                 ^^^ move it 
>>>> messages, called tx_complete_batch(). This change will come in
>>>          ^^^ here 
>>
>> Nope. Beforehand there was no a single route, and *now* there is a
>> single route. Which happened to be called tx_complete_batch(). The
>> accent is on *now there is a single route*. Not on *now it is called*.
> 
> What I mean is actually "Also there is a single route for commit and
> rollback cbus messages now, called tx_complete_batch(). 

Aha, ok. Changed to your version.