From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id AC8AC5B18EA; Wed, 4 Oct 2023 12:01:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AC8AC5B18EA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1696410084; bh=AwPex5WXJyUmzTVMdMpWgppiA7HjvhAPbuHX6SWa09Y=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=hoebs2DYOXRyDsrFk0ck6CSn3vufZAtfefT9nXVPKNxdMjZ6WbhpLXuJimNdg/OiR nzPrHtYEl1C6OB0CNbdo85EWvyfNjlMiOyxhYzGqt2GA2JBlBoBhaBtMnnSnMXjkgh sXmn/p/29RkQAxzHnfmDgFTI+MQFbeKyV1zgIEk8= Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [95.163.41.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id ED3A55B18EA for ; Wed, 4 Oct 2023 12:01:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ED3A55B18EA Received: by smtp31.i.mail.ru with esmtpa (envelope-from ) id 1qnxkw-008qWs-1b; Wed, 04 Oct 2023 12:01:22 +0300 Message-ID: <36d3cdb5-36d4-45a2-aea4-57f44e5ce183@tarantool.org> Date: Wed, 4 Oct 2023 12:01:22 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org, skaplun@tarantool.org, imun@tarantool.org References: <20230918142642.76199-1-m.kokryashkin@tarantool.org> In-Reply-To: <20230918142642.76199-1-m.kokryashkin@tarantool.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD905284D235AF2CB53BB6873EB345F06024B28541675B4B6EE182A05F5380850404C228DA9ACA6FE27C4971DEFB995A335AEAAC8B3924B13A69742469ADFE141CA7F5A2F5385070909 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7922E451CE6E839B1EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375B4C42A189C515578638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D88051D99D577C175903D261361A40F992117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF77088377309FF52A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10FC26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE26055571C92BF10F302FCEF25BFAB3454AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3A367EA73E0D98AAD76E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C22494854413538E1713FE827F84554CEF50127C277FBC8AE2E8B2EE5AD8F952D28FBAAAE862A0553A39223F8577A6DFFEA7C5351985B4A98E2A443847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5696C2B881E680D97A8188FF5DB62A4462617059427D3AE22F87CCE6106E1FC07E67D4AC08A07B9B082B967D547A19D2FCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3463DBE2ADA183F62F1BDC7EEF736124E0A883A595C6EFB1A94AA596F9095939A15D21E13ADC52BB381D7E09C32AA3244C6CAD2399A6DB3F887362248394213E1D5A1673A01BA68E40ED9A463B7D0AAFF65DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojS50qH6HnxT1rst4T7y66hA== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A7697842D66E4F5A3F54AEAAC8B3924B13A67CF96F699FB25259EBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] debug: generalized extension X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Max On 9/18/23 17:26, Maxim Kokryashkin wrote: > This patch joins the LLDB and GDB LuaJIT debugging extensions > into one, so now the extension logic can be debugger-agnostic. > To do that, an adapter class is introduced, and all of the > debugger-specific behavior is encapsulated there. The extension > auto-detects the debugger it was loaded into and selects the > correct low-level logic implementation. > --- > Branch: https://github.com/tarantool/luajit/tree/fckxorg/generalized-debugger > src/luajit-gdb.py | 885 -------------------------- > src/{luajit_lldb.py => luajit_dbg.py} | 617 ++++++++++++------ > 2 files changed, 417 insertions(+), 1085 deletions(-) There is a diff with 2k lines. How does one can make sure that there are no regressions after refactoring?