From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DA20247E8E9; Mon, 29 May 2023 17:38:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DA20247E8E9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1685371121; bh=R1d5ujscU21zFBUvmSvjsFJRx8QWyYA3vg5GBSGx7bo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=japIc+e03Phad6fVBpyOg4LpUEXnqca+cjOfV7P8MM5BypDJI2SLyu0+JMhp1pIWg 1x/1KO8YZmilZVofc9oEll5TgwLufvJIfGRBeCZSOoAgkFVXtd/7aPxO2/lsVjgO3x m4Ta9Zv0hKb9Or63MuI4Wsb/phXZaHqBmw9VRcp8= Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [95.163.41.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1494847DF11 for ; Mon, 29 May 2023 17:38:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1494847DF11 Received: by smtp35.i.mail.ru with esmtpa (envelope-from ) id 1q3e1A-00FrER-66; Mon, 29 May 2023 17:38:40 +0300 Message-ID: <367ae480-e546-697d-0269-9c081913f0ad@tarantool.org> Date: Mon, 29 May 2023 17:38:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Sergey Kaplun References: <4564f805b390388473afa982db5cf3235f1cbaad.1684442182.git.skaplun@tarantool.org> <467c6552-2cc8-7097-6d86-bb8c9628bb84@tarantool.org> <1be152d0-9c74-0751-2473-2211ed32d625@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9FA9FE7958A526B7720A7778064FAD46CFFAE4421AB0E3E4100894C459B0CD1B99FE1BA7559F5223D77CC0B18BAAA260F26B686E80FE633A88EDB03A1592C0308 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76C0A440987CA342DC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE78AC0750F3304E924EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BE5CCB53A13BC8DBACBC3ECABE81A2867C6640A8D7DDDAAC6CC7F00164DA146DAFE8445B8C89999728AA50765F79006372255A60090D554F4389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8AC824117EA787438117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CFD54AF0CDAA4A5DE6BA3038C0950A5D36C8A9BA7A39EFB766EC990983EF5C0329BA3038C0950A5D36D5E8D9A59859A8B6BD4495EC84D707EE76E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C468D16C903838CAB43847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5685D6C9548A9A45D485C9D3E71EEE1694487A0A103D37D3CF87CCE6106E1FC07E67D4AC08A07B9B0DB8A315C1FF4794DBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34C2BE7381A0AD3DF1B4878BEA44839D33685F1683A7A05B4DF27EDE2627BA621F291B1977388807361D7E09C32AA3244C209477DC42EA87D5A09FDC561EF09CFBCE0B41342B755BCD927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojjwJ7vqadnRto7imqRMZl4g== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A7695B62184E701CB4E9C4C1BC6CD694A72E81AE5054A97140B9EBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 2/6] test: introduce module for C tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This patch is LGTM after fixing typo below. On 5/29/23 13:03, Sergey Kaplun wrote: > >>> =================================================================== >> This test checks that macroses/functions in test.h could be called and >> nothing more. >> >> We need checking TAP output that binary will emit for different test >> statuses, plan, testcase counters ("1..10"). > As discussed offline: its not the main goal of this suite introducing, > also, TAP13 protocol is tested by `prove` itself, and fully compatible > with TAP14 protocol. Also, added the following check of parsing to be > sure in the emmited format correctness. > > =================================================================== > diff --git a/test/tarantool-c-tests/CMakeLists.txt b/test/tarantool-c-tests/CMakeLists.txt > index bf98856f..1aade851 100644 > --- a/test/tarantool-c-tests/CMakeLists.txt > +++ b/test/tarantool-c-tests/CMakeLists.txt > @@ -36,6 +36,9 @@ add_custom_command(TARGET tarantool-c-tests > ${CMAKE_CURRENT_BINARY_DIR} > --ext ${C_TEST_SUFFIX} > --jobs ${CMAKE_BUILD_PARALLEL_LEVEL} > + # Reportt any TAP parse errors, if any, since test module is Typo: Reportt -> Report > + # maintained by us. > + --parse > ${C_TEST_FLAGS} > WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} > =================================================================== > > Also, mentioned this in the commit message: > > | The library itself is tested via some primitive tests for `ok` case, > | `skip` and `todo` directives. The TAP13 format is tested via prove, that > | we are using for running our tests. TAP14 format is compatible with > | TAP13, so there are no other tests required. > > > >