From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 411EC2A8B1 for ; Thu, 21 Mar 2019 11:36:46 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9-7VxTsCMYZ3 for ; Thu, 21 Mar 2019 11:36:46 -0400 (EDT) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id D44E12A89A for ; Thu, 21 Mar 2019 11:36:45 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v2 3/9] box: fix Tarantool upgrade from 2.1.0 to 2.1.1 References: <1e4434445b60b5a5e0c3b289505595b0e00c8f8c.1548838034.git.kshcherbatov@tarantool.org> <4F67EA78-E237-4424-BEF6-ECE8ADCD5CBF@tarantool.org> <860C81EF-4B1E-4648-A638-C804DB32A3EF@tarantool.org> <628af1ea-16b5-b805-016a-05d7a6866944@tarantool.org> <664503E3-9B26-46D1-87DC-1FE1EEB97C90@tarantool.org> From: Vladislav Shpilevoy Message-ID: <36793b83-12fa-d4af-90ec-88d02da0de7b@tarantool.org> Date: Thu, 21 Mar 2019 18:36:41 +0300 MIME-Version: 1.0 In-Reply-To: <664503E3-9B26-46D1-87DC-1FE1EEB97C90@tarantool.org> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, "n.pettik" Cc: Kirill Yukhin , Konstantin Osipov Hi! I remember about that. Just have no time. I will review that tomorrow. On 21/03/2019 18:23, n.pettik wrote: > Guys, please, don’t ignore this patch. It is vital for 2.1.1 release. > >> On 20 Mar 2019, at 18:38, Kirill Shcherbatov > wrote: >>>>> Tarantool could not start from the snapshot created by version >>>>> 2.1.0 because the new version 2.1.1 does not support the >>>>> index.opts.sql index opt and stops the execution. >>>>> Introduced a special state OPT_DEF_LEGACY macro to ignore legacy >>>>> options and introduced migration code in upgrade.lua. >>>> >>>> As for me, it looks satisfying, but I strongly recommend you to ask >>>> other members of server team for comments on this approach. >>>> Will there be other “legacy” options, or in the nearest future this is >>>> going to be the only one? Moreover, opts_parse_key already features >>>> “skip_unknown_options” param - could we skip “sql” option using it >>>> (ofc considering some workaround)? >>>> >>>> Again, since it is not directly related to the main patch-set, let’s >>>> consider it as independent. >>> >>> LGTM. >> >> I've rebased this separate patch on the branch >> kshch/migration-fixup >> you may cherry-pick it if it is really reasonable. >