From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0923E13EBF62; Fri, 6 Jun 2025 18:49:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0923E13EBF62 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1749224963; bh=WUGunyM0oKzIR+Taokd+dCTMTKJlelQza50Vwyd8ngw=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=X0MxY6k2+jbPBQrXer05M5u6KWaE5xPSZWVgWZ5k8vrs0/uf0mapyk1TAPAC79O9O zQiZ9nFIKPxnY69rQAbuaGOQmpzKGkZcEr4lP9e/0g3dTjv0svTvJWVHmsUSOq79Zo AdCUTezTLX1BmYYUFnwd/ZZMGmXTzlS58r5FoHRE= Received: from send241.i.mail.ru (send241.i.mail.ru [95.163.59.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5B86B13EBF62 for ; Fri, 6 Jun 2025 18:49:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5B86B13EBF62 Received: by exim-smtp-567cc788d4-2fngb with esmtpa (envelope-from ) id 1uNZJo-000000004Nx-2Ian; Fri, 06 Jun 2025 18:49:20 +0300 Content-Type: multipart/alternative; boundary="------------Ys7clBif6DPaTCgQpw13qgJV" Message-ID: <36145b26-9f2e-4983-b8d5-cb5e4012c9ef@tarantool.org> Date: Fri, 6 Jun 2025 18:49:20 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <5720c23a8dd4dbd5e2879b1ea163b7d140b0faf9.1749101434.git.skaplun@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD95E97EA1894635BC3577730E5842974C3FC041FD805BFA975182A05F538085040B0DC42DD7257A34E3DE06ABAFEAF6705D1E94242C5B1E726BEFFEB50C38A25C7DE81258B7D5E2227 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE771540F9ECFC94C4BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB5533756680FD86C7FE90CFE5A8F4A19298AAB23567FD31E991A3AD202746CBD4DD88FCCA389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0DEC8C2C8BCD2534D8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6E5E764EB5D94DBD4CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C22490F250D17497FEF6176E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8B8DBB596EC94336063AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735D2457FAF19517CF2C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5448EF287953E411A5002B1117B3ED69613C9EE712F6B9F2A54BB1175C6E7DD94823CB91A9FED034534781492E4B8EEAD3CCD70CEBBF18A22BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34951738D4D62E58A49FD36130170E5AE135C538E6BAB87177709590173B21F9B48CA7E50162484EC01D7E09C32AA3244C91349B4AD78C54F677DD89D51EBB774215D8CCB887B2CA0CEA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVSykAyseJQ6/NJwTxebL0GU= X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D614016403D9C02290D5ED4FF92D56319F197B36A299B97607D7F0152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/3] Fix potential file descriptor leak in luaL_loadfile*(). X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------Ys7clBif6DPaTCgQpw13qgJV Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit LGTM On 6/6/25 18:14, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > > On 06.06.25, Sergey Bronnikov wrote: >> Hello, Sergey, >> >> the test is passed when CMake option -DLUAJIT_USE_VALGRIND=ON is used and >> >> patch with fix is reverted. > You should run it with the corresponding env variable (like it is done > in the CI), see the comment in the test header: > > | VALGRIND_OPTS="--track-fds=yes" ctest -V -R lj-1249 It works, thanks, but the test is still passed. In  private conversation, we have found a reason - I have a version of Valgrind, that doesn't fail on detected fd leak: Release 3.24.0 (31 Oct 2024) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ... * ==================== CORE CHANGES =================== * Bad file descriptor usage now generates a real error with   --track-fds=yes that is suppressible and shows up in the xml output   with full execution backtrace. The warnings shown without using the   option are deprecated and will be removed in a future valgrind   version. The same behavior is in our CI, because Valgrind 3.24.0 is in 25.04+, but in GHA the latest version is 24.04. 1. https://repology.org/project/valgrind/versions 2. https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners >> Sergey --------------Ys7clBif6DPaTCgQpw13qgJV Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

LGTM

On 6/6/25 18:14, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review!

On 06.06.25, Sergey Bronnikov wrote:

Hello, Sergey,

the test is passed when CMake option -DLUAJIT_USE_VALGRIND=ON is used and

patch with fix is reverted.

You should run it with the corresponding env variable (like it is done
in the CI), see the comment in the test header:

| VALGRIND_OPTS="--track-fds=yes" ctest -V -R lj-1249

It works, thanks, but the test is still passed.

In  private conversation, we have found a reason - I have a version of Valgrind,

that doesn't fail on detected fd leak:

Release 3.24.0 (31 Oct 2024)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~

...

* ==================== CORE CHANGES ===================

* Bad file descriptor usage now generates a real error with
  --track-fds=yes that is suppressible and shows up in the xml output
  with full execution backtrace. The warnings shown without using the
  option are deprecated and will be removed in a future valgrind
  version.

The same behavior is in our CI, because Valgrind 3.24.0 is in 25.04+, but in GHA the latest version is 24.04.

1. https://repology.org/project/valgrind/versions

2. https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners


      

        
Sergey


      

      

    

  
  


--------------Ys7clBif6DPaTCgQpw13qgJV--