From: "Alexander V. Tikhonov" <avtikhon@tarantool.org> To: Kirill Yukhin <kyukhin@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH v1] test: fix hang of vinyl/select_consistency.* test Date: Mon, 9 Nov 2020 15:57:12 +0300 [thread overview] Message-ID: <35a75c370ee7e6135322c38ffe575c18da34cffe.1604926554.git.avtikhon@tarantool.org> (raw) During testing process: https://gitlab.com/tarantool/tarantool/-/jobs/800863457#L5303 found that test vinyl/select_consistency.test.lua hanged: --- vinyl/select_consistency.result Thu Jun 11 11:59:48 2020 +++ var/152_vinyl/select_consistency.result Tue Oct 20 09:13:02 2020 @@ -137,16 +137,3 @@ for i = 1, ch:size() do ch:get() end; ---- -... -test_run:cmd("setopt delimiter ''"); ---- -- true -... This issue stops the testing till the complete timeout of the test-run will stop all the testing process. To avoid of it 'wait_cond()' routine was added to 'ch:get()' command to set it's local timeout to avoid of waiting for test-run global timeout. Needed for #4385 --- Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4385_hang_select_consistency Issue: https://github.com/tarantool/tarantool/issues/4385 test/vinyl/select_consistency.result | 2 +- test/vinyl/select_consistency.test.lua | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/vinyl/select_consistency.result b/test/vinyl/select_consistency.result index f27d0ec68..5a23a674b 100644 --- a/test/vinyl/select_consistency.result +++ b/test/vinyl/select_consistency.result @@ -135,7 +135,7 @@ stop = true; --- ... for i = 1, ch:size() do - ch:get() + test_run:wait_cond(function() return ch:get() end) end; --- ... diff --git a/test/vinyl/select_consistency.test.lua b/test/vinyl/select_consistency.test.lua index 73b443e89..6398d09cd 100644 --- a/test/vinyl/select_consistency.test.lua +++ b/test/vinyl/select_consistency.test.lua @@ -102,7 +102,7 @@ end; stop = true; for i = 1, ch:size() do - ch:get() + test_run:wait_cond(function() return ch:get() end) end; test_run:cmd("setopt delimiter ''"); -- 2.25.1
next reply other threads:[~2020-11-09 12:57 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-09 12:57 Alexander V. Tikhonov [this message] 2020-11-15 18:43 Alexander V. Tikhonov 2020-11-16 21:06 ` Nikita Pettik 2020-12-02 18:57 ` Alexander V. Tikhonov 2020-12-07 12:26 ` Nikita Pettik
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=35a75c370ee7e6135322c38ffe575c18da34cffe.1604926554.git.avtikhon@tarantool.org \ --to=avtikhon@tarantool.org \ --cc=kyukhin@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v1] test: fix hang of vinyl/select_consistency.* test' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox