From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 9A2B720FBA for ; Mon, 23 Jul 2018 09:23:11 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qyHhTJ4exPL5 for ; Mon, 23 Jul 2018 09:23:11 -0400 (EDT) Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [94.100.177.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id EFB9120EB7 for ; Mon, 23 Jul 2018 09:23:10 -0400 (EDT) From: Georgy Kirichenko Subject: [tarantool-patches] Re: [PATCH] lua: fix for option changed by tarantoolctl Date: Mon, 23 Jul 2018 16:23:08 +0300 Message-ID: <3578005.8AOcFEYhFo@localhost> In-Reply-To: <20180720165359.8718-1-k.belyavskiy@tarantool.org> References: <20180720165359.8718-1-k.belyavskiy@tarantool.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2442261.d68v1sKuAm"; micalg="pgp-sha256"; protocol="application/pgp-signature" Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Konstantin Belyavskiy --nextPart2442261.d68v1sKuAm Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" I am sorry but it is completelly wrong > + if cfg.pid_file ~= default_cfg.pid_file then > + log.warn("then using with tarantoolctl option 'pid_file' is > ignored") + cfg.pid_file = default_cfg.pid_file > + end How should this fix the issue? > - box.error(box.error.RELOAD_CFG, key); > + -- then started with tarantoolctl this option is set to > + -- default value, see #3214. > + if key == "pid_file" then What is it "pid_file"? --nextPart2442261.d68v1sKuAm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEFZT35EtIMRTDS5hJnoTdFFzh6LUFAltV1rwACgkQnoTdFFzh 6LWT8AgAjYHPWp61uKWaV3vsHrX1/GANVVoj5WQKc2XMBKnRnZyl7wGCH9Yh32ay izyysHWc44WWhjVq3/k4ybK2aywChCIo7OLpfhRGRDYdYf6+Vl42kQUoOUFjNulr KpJnwGJlYFmnia3UzTyg7TzsEKZGYDRg5C13bruNGoHoJaQnfXt+TQsZ8+P/kYPN xZg23Lr14brHBwmupuB45WzScMBu/7gHRluy5oPNEqtDJ10itHc5ITHRpw+j8/A4 0VQ0UzMwNS9MQxp7cqZHZKxIC6yOYdx/MtfiVPJKME+zv4j4qcfRJMbPbUhO+S2/ aZm51FhHzTAiieltGcSM6iWUH6VdVw== =SQ8I -----END PGP SIGNATURE----- --nextPart2442261.d68v1sKuAm--