From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 856BC445320
 for <tarantool-patches@dev.tarantool.org>;
 Sun,  5 Jul 2020 11:40:38 +0300 (MSK)
References: <cover.1593733161.git.v.shpilevoy@tarantool.org>
 <2108e63a8386c036f43e6cf01666587541e18e61.1593733161.git.v.shpilevoy@tarantool.org>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <3553d0d7-a15b-193d-869e-b84b74b3754f@tarantool.org>
Date: Sun, 5 Jul 2020 11:40:36 +0300
MIME-Version: 1.0
In-Reply-To: <2108e63a8386c036f43e6cf01666587541e18e61.1593733161.git.v.shpilevoy@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [Tarantool-patches] [PATCH 2/5] [tosquash] applier: remove
 unnecessary fiber name check
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org


03.07.2020 02:40, Vladislav Shpilevoy пишет:
> This was an artifact from a first version of the patch.
> Of course it is not valid, because final commit of this
> transaction can be done by any fiber.

Hi! Thanks for the patch! LGTM.

> ---
>   src/box/applier.cc | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/src/box/applier.cc b/src/box/applier.cc
> index 7e70211b7..9a9ec1dac 100644
> --- a/src/box/applier.cc
> +++ b/src/box/applier.cc
> @@ -806,7 +806,6 @@ applier_txn_commit_cb(struct trigger *trigger, void *event)
>   	(void) trigger;
>   	struct txn *txn = (struct txn *)event;
>   	assert(txn->fiber != NULL);
> -	assert(strncmp(txn->fiber->name, "applierw", 8) == 0);
>   	/*
>   	 * Let the txn module free the transaction object. It is
>   	 * not needed for anything else.

-- 
Serge Petrenko