From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CA073469719 for ; Thu, 27 Feb 2020 03:25:20 +0300 (MSK) References: <20200226082029.GA5040@atlas> From: Vladislav Shpilevoy Message-ID: <352307e9-cc71-2f26-8beb-148a3e0cd3de@tarantool.org> Date: Thu, 27 Feb 2020 01:25:18 +0100 MIME-Version: 1.0 In-Reply-To: <20200226082029.GA5040@atlas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH vshard 1/1] router: bucket_id_strcrc32 and bucket_id_mpcrc32 List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Konstantin Osipov , tarantool-patches@dev.tarantool.org, olegrok@tarantool.org On 26/02/2020 09:20, Konstantin Osipov wrote: > * Vladislav Shpilevoy [20/02/26 09:31]: >> Closes #207 > > While you're at it, is this hardware crc32? Yes, this is hardware, when possible. And it is in C. See crc32.c files (there are two of them). > > Did you consider implementing it in C as a server built-in to > avoid using messagepack as an interim representation? MessagePack is chosen not because of speed (although it is the same as with tostring(), according to my benches, and even a little faster on numbers), but because of bad representation of Lua cdata numbers in strings.